Date: Tue, 8 Jan 2019 22:12:08 +0100 From: Tobias Kortkamp <tobik@freebsd.org> To: Sean Bruno <sbruno@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <20190108211207.GA71800@urd.tobik.me> In-Reply-To: <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me> <b472df4d-574e-09f8-6212-687209d31bbc@freebsd.org> <0a880448-8ef7-76ff-e531-929dbce9ccf3@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 08, 2019 at 11:44:57AM -0700, Sean Bruno wrote: >=20 >=20 > On 1/8/19 10:23 AM, Sean Bruno wrote: > >=20 > >=20 > > On 1/3/19 4:23 PM, Tobias Kortkamp wrote: > >>> > >>> On 1/3/19 2:54 PM, Tobias Kortkamp wrote: > >>>>> +USE_QT=3D buildtools \ > >>>> Does clementine-player, a music player, really need qt5-buildtools > >>>> at runtime or should this be buildtools_build instead? > >>>> > >>>>> + concurrent \ > >>>>> + core \ > >>>>> dbus \ > >>>>> gui \ > >>>>> imageformats \ > >>>>> - qmake_build \ > >>>>> linguist_build \ > >>>>> - moc_build \ > >>>>> network \ > >>>>> opengl \ > >>>>> - qtestlib \ > >>>>> - rcc_build \ > >>>>> + qmake_build \ > >>>>> + testlib \ > >>>> Same here. Does it really need qt5-testlib at runtime? > >>>> > >>> Probably not? > >>> > >>> sean > >>> > >> So I guess they are not needed at runtime. Will you change them > >> to build dependencies? > >=20 > > Yeah, I'll look at it today. Thanks! > >=20 > > sean > >=20 >=20 >=20 > Something like this will solve this runtime/buildtime depend issue? > Obviously, I'll buildtime/runtime test it before commit. >=20 > Index: audio/clementine-player/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- audio/clementine-player/Makefile (revision 489727) > +++ audio/clementine-player/Makefile (working copy) > @@ -41,7 +41,7 @@ > USE_GL=3D gl glew glu > USE_XORG=3D x11 >=20 > -USE_QT=3D buildtools \ > +USE_QT=3D buildtools_build \ > concurrent \ > core \ > dbus \ > @@ -51,7 +51,7 @@ > network \ > opengl \ > qmake_build \ > - testlib \ > + testlib_build \ > sql \ > widgets \ > x11extras \ >=20 Yes, thanks. This looks fine to me. --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAlw1EiVfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2GbJwgAsO214aA2eP8ub+5BbZ+S3BHLYr1CPNxCCG+KPhh1ekIBdkAPqEpvVwv8 K4FfZPHsjVqbaQeZGIfBHhPbHL4Jkhs4gYecGVBjkvp2Lea4UT1ZAmoYtKFKK4ZF nfj7IDiCdZlecUiJqXigAIxRf6HUq5iLKaI+As9uQE27teAtwQXjZVp1e22UHg5K UqRrO1B/fzV7KZ1NntSVJJexyZrp9xe/xhdTm9MRzES2+fdq7E8ytzlkAjZZx6nL Pmw4IZg2u6Ncvtf/f5rY2Hc6E3jZj4rPhz3EYoexKXXxmjwB1PZbPu3jLNyF/pNW qiTpYgy3RSDPdrRvbW/LtM9GTnNrVw== =E8Fr -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190108211207.GA71800>