From owner-cvs-src@FreeBSD.ORG Tue Oct 10 09:20:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6985816A407; Tue, 10 Oct 2006 09:20:55 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37A2443D46; Tue, 10 Oct 2006 09:20:55 +0000 (GMT) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k9A9KtT5089683; Tue, 10 Oct 2006 09:20:55 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k9A9KthM089673; Tue, 10 Oct 2006 09:20:55 GMT (envelope-from kib) Message-Id: <200610100920.k9A9KthM089673@repoman.freebsd.org> From: Konstantin Belousov Date: Tue, 10 Oct 2006 09:20:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/ufs/ffs ffs_inode.c ffs_snapshot.c ffs_vnops.c src/sys/ufs/ufs inode.h ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2006 09:20:55 -0000 kib 2006-10-10 09:20:54 UTC FreeBSD src repository Modified files: sys/ufs/ffs ffs_inode.c ffs_snapshot.c ffs_vnops.c sys/ufs/ufs inode.h ufs_vnops.c Log: Do not translate the IN_ACCESS inode flag into the IN_MODIFIED while filesystem is suspending/suspended. Doing so may result in deadlock. Instead, set the (new) IN_LAZYACCESS flag, that becomes IN_MODIFIED when suspend is lifted. Change the locking protocol in order to set the IN_ACCESS and timestamps without upgrading shared vnode lock to exclusive (see comments in the inode.h). Before that, inode was modified while holding only shared lock. Tested by: Peter Holm Reviewed by: tegge, bde Approved by: pjd (mentor) MFC after: 3 weeks Revision Changes Path 1.107 +7 -5 src/sys/ufs/ffs/ffs_inode.c 1.131 +18 -6 src/sys/ufs/ffs/ffs_snapshot.c 1.161 +8 -2 src/sys/ufs/ffs/ffs_vnops.c 1.51 +9 -0 src/sys/ufs/ufs/inode.h 1.280 +47 -21 src/sys/ufs/ufs/ufs_vnops.c