From owner-svn-src-all@freebsd.org  Sat Apr 29 02:16:59 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CF37D5473F;
 Sat, 29 Apr 2017 02:16:59 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id B063B1D9B;
 Sat, 29 Apr 2017 02:16:58 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v3T2GpF4079683
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 28 Apr 2017 19:16:51 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id v3T2Gpsj079682;
 Fri, 28 Apr 2017 19:16:51 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Fri, 28 Apr 2017 19:16:51 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Alexander Motin <mav@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r317547 - head/sys/net
Message-ID: <20170429021651.GZ56922@FreeBSD.org>
References: <201704281100.v3SB0wgY005696@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201704281100.v3SB0wgY005696@repo.freebsd.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Apr 2017 02:16:59 -0000

On Fri, Apr 28, 2017 at 11:00:58AM +0000, Alexander Motin wrote:
A> Author: mav
A> Date: Fri Apr 28 11:00:58 2017
A> New Revision: 317547
A> URL: https://svnweb.freebsd.org/changeset/base/317547
A> 
A> Log:
A>   Allow some control over enabled capabilities for if_vlan.
A>   
A>   It improves interoperability with if_bridge, which may need to disable
A>   some capabilities not supported by other members.  IMHO there is still
A>   open question about LRO capability, which may need to be disabled on
A>   physical interface.
A>   
A>   MFC after:	2 weeks
A>   Sponsored by:	iXsystems, Inc.

On quick glance this looks like the opposite to what was done in r281885.

As discussed back 2 years ago:

- There are no NICs that are able to have different set of capabilities
turned on on different VLANs, and unlikely such will appear.
- Capabilities should be switched on VLAN trunk.
- Allowing to switch capabilities on a VLAN with magical flip of properties
  of all the VLANs on the same trunk is an ugly design. This is something
  unexpected for a sysadmin. Better refuse that and make him toggle properties
  on the trunk explicitily.

-- 
Totus tuus, Glebius.