Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Jan 2013 13:13:15 +0000
From:      Chris Rees <utisoft@gmail.com>
To:        MANTANI Nobutaka <nobutaka@freebsd.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r311003 - head/editors/apel
Message-ID:  <CADLo838fffwR=sp83d%2BZE_0SKFga2u7AbxhGOq0Y0YoL1bbzFg@mail.gmail.com>
In-Reply-To: <201301261052.r0QAq3aA066673@svn.freebsd.org>
References:  <201301261052.r0QAq3aA066673@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 26 Jan 2013 10:52, "MANTANI Nobutaka" <nobutaka@freebsd.org> wrote:
>
> Author: nobutaka
> Date: Sat Jan 26 10:52:03 2013
> New Revision: 311003
> URL: http://svnweb.freebsd.org/changeset/ports/311003
>
> Log:
>   Update MASTER_SITES and WWW.
>   Add license information.
>   Adopt OptionsNG.
>   Trim Makefile header.
>
>   PR:           ports/175277  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=175277
>   Submitted by: Yasuhiro KIMURA <yasu@utahime.org>
>
> Modified:
>   head/editors/apel/Makefile
>   head/editors/apel/pkg-descr
>
> Modified: head/editors/apel/Makefile
> ==============================================================================
> --- head/editors/apel/Makefile  Sat Jan 26 10:37:03 2013        (r311002)
> +++ head/editors/apel/Makefile  Sat Jan 26 10:52:03 2013        (r311003)
> @@ -1,20 +1,18 @@
> -# New ports collection makefile for:   apel for emacs
> -# Date created:                23 September 1998
> -# Whom:                        Shigeyuki FUKUSHIMA <shige@FreeBSD.org>
> -#
> +# Created by: Shigeyuki FUKUSHIMA <shige@FreeBSD.org>
>  # $FreeBSD$
> -#
>
>  PORTNAME=      apel
>  PORTVERSION=   ${APEL_VER}
>  PORTREVISION=  8
>  CATEGORIES=    editors elisp
> -MASTER_SITES=  http://kanji.zinbun.kyoto-u.ac.jp/~tomo/lemi/dist/apel/
> +MASTER_SITES=  http://git.chise.org/elisp/dist/apel/
>  PKGNAMESUFFIX= -${EMACS_PORT_NAME}
>
>  MAINTAINER?=   nobutaka@FreeBSD.org
>  COMMENT?=      A Portable Emacs Library for emacs
>
> +LICENSE=       GPLv2
> +
>  # distfile version
>  APEL_VER=      10.8
>  # apel lispdir
> @@ -33,6 +31,10 @@ MAKE_ARGS+=  PREFIX="${LOCALBASE}" \
>                 LISPDIR="${APEL_LISPDIR}" \
>                 VERSION_SPECIFIC_LISPDIR="${APEL_VERSION_SPECIFIC_LISPDIR}"
>
> +OPTIONS_DEFINE=        DOCS
> +OPTINOS_DEFAULT=       DOCS

Apart from the typo, please don't add OPTIONS_DEFINE if the only
option is DOCS; putting up an OPTIONS screen for something that should
be globally set is very annoying.  DOCS is recognised by
bsd.options.mk anyway.

> +.include <bsd.port.options.mk>
>  .include <bsd.port.pre.mk>

No need for the explicit options.mk.

>  .if ${EMACS_VER:C/\..*//} >= 23
> @@ -42,7 +44,7 @@ PLIST_SUB+=   EMACS23="@comment " NOEMACS2
>  .endif
>
>  post-install:
> -.if !defined(NOPORTDOCS)
> +.if ${PORT_OPTIONS:MDOCS}
>         @${MKDIR} ${DOCSDIR}
>         @(cd ${WRKSRC} ; \
>         for i in ChangeLog README.* ; do \
>
> Modified: head/editors/apel/pkg-descr
> ==============================================================================
> --- head/editors/apel/pkg-descr Sat Jan 26 10:37:03 2013        (r311002)
> +++ head/editors/apel/pkg-descr Sat Jan 26 10:52:03 2013        (r311003)
> @@ -29,4 +29,4 @@ To use apel, put the following setup int
>
>         (require 'apel-setupel)
>
> -WWW: http://www.kanji.zinbun.kyoto-u.ac.jp/~tomo/elisp/APEL/index.en.html
> +WWW: http://git.chise.org/elisp/apel/index.html.en
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo838fffwR=sp83d%2BZE_0SKFga2u7AbxhGOq0Y0YoL1bbzFg>