From owner-freebsd-cvsweb Wed Jul 3 14:25:52 2002 Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4692B37B401 for ; Wed, 3 Jul 2002 14:25:50 -0700 (PDT) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C1DA43E52 for ; Wed, 3 Jul 2002 14:25:49 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from cs78128057.pp.htv.fi ([62.78.128.57]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id g63LPe507288; Thu, 4 Jul 2002 00:25:41 +0300 (EETDST) Subject: Re: FW: [PATCH] fileSortCmp() should properly weed out rogue non-dir files From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: Khachaturov Vassilii Cc: "'cvsweb development'" In-Reply-To: <6B1DF6EEBA51D31182F200902740436803B24BB5@mail-in.comverse.com> References: <6B1DF6EEBA51D31182F200902740436803B24BB5@mail-in.comverse.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.3 (1.0.3-6) Date: 04 Jul 2002 00:25:49 +0300 Message-Id: <1025731551.5927.119.camel@bobcat.ods.org> Mime-Version: 1.0 Sender: owner-freebsd-cvsweb@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 2002-07-03 at 18:13, Khachaturov Vassilii wrote: > By knu's request, I am resubmitting the patch to this new mailing list. > (This is my 7th patch to cvsweb, but just the 1st one submitted here - > please > tell me if another patch format/attachment way is preferred on the list...) Both are fine with me, but it seems inlining works better with the archives as you already noticed. > BTW, the README et al. stuff in the project source should probably be > updated to refer to this list, as should be the default footer/header > project > info - right now it suggests posting changes directly to knu@freebsd.org. Yes, I already had a patch waiting, and it was committed a while ago. > P.P.S. For ChangeLog purposes, please use my other address Got that... > Subject: [PATCH] fileSortCmp() should properly weed out rogue non-dir files > > > ...otherwise the sorting order, if it is not name-base, is messed up. > > If your repository has no non-,v files in the repository subdirs, > > (no lock files etc.) then you aren't affected by this fix because you > > don't have the problem in the 1st place :-) Over here, I was mad at > > the occasional sort order breakage until I finally decided to debug it > > and noticed what's going on in the comparison routine by adding a > > trace there during the debug. > > > > When rogue files are present, all sort orders were affected, except > > the one based on the file name. Could you shed a bit more light on this, I can't verify the problem here. I'm unable to get non-,v files in the repo dirs to show up in CVSweb's directory listings or the sort orders to break... -\/ille To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-cvsweb" in the body of the message