Date: Fri, 3 Dec 1999 21:32:33 -0800 (PST) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: kris@hub.freebsd.org (Kris Kennaway) Cc: tstromberg@rtci.com, freebsd-audit@FreeBSD.ORG Subject: Re: More binaries with overflows. (7) Message-ID: <199912040532.VAA82253@gndrsh.dnsmgr.net> In-Reply-To: <Pine.BSF.4.21.9912031922230.4215-100000@hub.freebsd.org> from Kris Kennaway at "Dec 3, 1999 07:26:55 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, 3 Dec 1999 tstromberg@rtci.com wrote: > > > /usr/bin/fsplit arg overflow in -e, ex: fsplit -e [A*16384] > > This one is just gross. It needs to be rewritten. > > > /usr/bin/patch arg overflow, ex: patch -r [A*16384] > > OpenBSD have a bunch of tempfile fixes as well as the buffer overflow > fixes which should be merged. > > > /usr/bin/pr arg overflow, ex: pr -s [A*16384] > > This one was just a simple bug :) > > > /usr/bin/ypcat arg overflow in -d, ex: ypcat -d [A*16384] blah > > This one was a buffer overflow in libc which I'm testing a patch for now. > > I haven't checked the others yet Good work Kris, but I have a point about your commits, I didn't see any ``reviewed by's: for them and you've now hidden the old flaw from one of the only automated tools we have for finding these types of flaws :-( -audit related fixes should really be very carefuly eyeballed by a few reviewers, too often in the past hasty patch work by even the best of security programmers has related to harder to find security bugs. -- Rod Grimes - KD7CAX @ CN85sl - (RWG25) rgrimes@gndrsh.dnsmgr.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912040532.VAA82253>