Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Dec 2013 00:25:26 +0000 (UTC)
From:      Jean-Sebastien Pedron <dumbbell@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-releng@freebsd.org
Subject:   svn commit: r259367 - releng/10.0/sys/dev/drm2/radeon
Message-ID:  <201312140025.rBE0PQmo098716@svn.freebsd.org>

Next in thread | Raw E-Mail | Index | Archive | Help
Author: dumbbell
Date: Sat Dec 14 00:25:25 2013
New Revision: 259367
URL: http://svnweb.freebsd.org/changeset/base/259367

Log:
  MFC r259234:
  
  drm/radeon: agp_info->ai_aperture_size is in bytes, not Mbytes
  
  This fixes radeon_agp_init() and gtt_size is now correct. However, this
  is not enough to make Radeon AGP cards work: ttm_agp_backend.c isn't
  implemented yet.
  
  Submitted by:	tijl@
  Approved by:	re (gjb)

Modified:
  releng/10.0/sys/dev/drm2/radeon/radeon_agp.c
Directory Properties:
  releng/10.0/   (props changed)

Modified: releng/10.0/sys/dev/drm2/radeon/radeon_agp.c
==============================================================================
--- releng/10.0/sys/dev/drm2/radeon/radeon_agp.c	Sat Dec 14 00:23:43 2013	(r259366)
+++ releng/10.0/sys/dev/drm2/radeon/radeon_agp.c	Sat Dec 14 00:25:25 2013	(r259367)
@@ -153,11 +153,11 @@ int radeon_agp_init(struct radeon_device
 		return ret;
 	}
 
-	if (rdev->ddev->agp->info.ai_aperture_size < 32) {
+	if ((rdev->ddev->agp->info.ai_aperture_size >> 20) < 32) {
 		drm_agp_release(rdev->ddev);
 		dev_warn(rdev->dev, "AGP aperture too small (%zuM) "
 			"need at least 32M, disabling AGP\n",
-			rdev->ddev->agp->info.ai_aperture_size);
+			rdev->ddev->agp->info.ai_aperture_size >> 20);
 		return -EINVAL;
 	}
 
@@ -246,7 +246,7 @@ int radeon_agp_init(struct radeon_device
 	}
 
 	rdev->mc.agp_base = rdev->ddev->agp->info.ai_aperture_base;
-	rdev->mc.gtt_size = rdev->ddev->agp->info.ai_aperture_size << 20;
+	rdev->mc.gtt_size = rdev->ddev->agp->info.ai_aperture_size;
 	rdev->mc.gtt_start = rdev->mc.agp_base;
 	rdev->mc.gtt_end = rdev->mc.gtt_start + rdev->mc.gtt_size - 1;
 	dev_info(rdev->dev, "GTT: %juM 0x%08jX - 0x%08jX\n",



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?201312140025.rBE0PQmo098716>