From owner-svn-src-head@freebsd.org Thu Feb 23 20:31:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C76F9CEA2ED for ; Thu, 23 Feb 2017 20:31:54 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wr0-x22a.google.com (mail-wr0-x22a.google.com [IPv6:2a00:1450:400c:c0c::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 60BB68B for ; Thu, 23 Feb 2017 20:31:54 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wr0-x22a.google.com with SMTP id s27so1314204wrb.2 for ; Thu, 23 Feb 2017 12:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=7Zkc0DaRWucIW8IWV6PsQzHVU6pJpoy5Kc6Hk8wAGlY=; b=hzDZunREa8mo9Q5EshjLhZUeqyZq+/9n16JkzQy2lfumwKYGstkeix9JAJ3TQebBsk bJwUugcd3l2vtn+kde4zMftOX9aV7yaiEqzOyNYE56zf96KrKBlhm276DP3EwsmXwCkg u5/ugyO+1W3pAhIVlUy0MtcCvW5MH3zul89HS5dFhX+9MJEG9pByRSz0AhOYPEKtzXAr H+C5ERC+e69WiSaU0xDpfal8WOUSqGbfQyiCIg6QX6KRgJ2Zmbbyj3PDkuFOwTm5F2CJ uZxGa84yvZ7l+7fwiVwVKwALxrLp7/lmE91npe7SATQXBbNk3o2T5KOJHlSKYSuhqhQ/ mekQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=7Zkc0DaRWucIW8IWV6PsQzHVU6pJpoy5Kc6Hk8wAGlY=; b=X5ik1oXkSOYcBtnpvY+bibx5uL2QusRmavh/YZrcV66Xp4lboRfjoCuc9Gpv+sRhwX Y/EnuAaXWnzZUWamZrVQxV/Wz6NAtJ/1HuKUJWwFqgMh0YMrCnXN0hxZkt7Tc/fJmSVc Be45jIhRVIDNoMuuTSaGNxwMR0i85oxzMz9JjyuYqufWiaa/2Ypa7cxcWUSBAZ899kzS 1SgWwpmCU5gMJVNTXpmcHfY2u8aEUFA26nHso/fJt98FqxyxdEvmu2mNl5PV5ai05VNe kPVdLxNifADmcgbnIEQzA8S9geUSThzlIYL4lQwQJsBxu9Mb5xFcuLeE2zfBP4n6KL+D yNJA== X-Gm-Message-State: AMke39mqFpHydN274qaBarD4P297hm3z0zgqMN5ouIr+7GttNp8TH8EBBpQoGTVdShIfc1TJ X-Received: by 10.223.154.210 with SMTP id a76mr28258869wrc.193.1487881912702; Thu, 23 Feb 2017 12:31:52 -0800 (PST) Received: from [10.10.1.58] ([185.97.61.4]) by smtp.gmail.com with ESMTPSA id j39sm7408389wrj.45.2017.02.23.12.31.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Feb 2017 12:31:52 -0800 (PST) Subject: Re: svn commit: r314155 - head/sys/netinet To: Michael Tuexen , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201702231814.v1NIEahd095397@repo.freebsd.org> From: Steven Hartland Message-ID: Date: Thu, 23 Feb 2017 20:31:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <201702231814.v1NIEahd095397@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 20:31:54 -0000 You might also be interested in reviewing my fix for TCP buffer scaling too Michael. https://reviews.freebsd.org/D9668 This fixes slow transfers due to no receive buffer scaling if TCP timestamps aren't negotiated. Its still got debug stuff in it ATM and I'm toying with removing the different cases between estimated RTT and timestamps as there appears to be no difference in practice. Tests here show jump from ~3MB/s @ 1Gbps and 17ms latency to 100MB/s, pretty much line rate, which is in line with Linux results. Any feedback welcome. Regards Steve On 23/02/2017 18:14, Michael Tuexen wrote: > Author: tuexen > Date: Thu Feb 23 18:14:36 2017 > New Revision: 314155 > URL: https://svnweb.freebsd.org/changeset/base/314155 > > Log: > TCP window updates are only sent if the window can be increased by at > least 2 * MSS. However, if the receive buffer size is small, this might > be impossible. Add back a criterion to send a TCP window update if > the window can be increased by at least half of the receive buffer size. > This condition was removed in r242252. This patch simply brings it back. > PR: 211003 > Reviewed by: gnn > MFC after: 1 week > Sponsored by: Netflix, Inc. > Differential Revision: https://reviews.freebsd.org/D9475 > > Modified: > head/sys/netinet/tcp_output.c > > Modified: head/sys/netinet/tcp_output.c > ============================================================================== > --- head/sys/netinet/tcp_output.c Thu Feb 23 17:56:24 2017 (r314154) > +++ head/sys/netinet/tcp_output.c Thu Feb 23 18:14:36 2017 (r314155) > @@ -696,6 +696,8 @@ after_sack_rexmit: > recwin <= (so->so_rcv.sb_hiwat / 8) || > so->so_rcv.sb_hiwat <= 8 * tp->t_maxseg)) > goto send; > + if (2 * adv >= (int32_t)so->so_rcv.sb_hiwat) > + goto send; > } > dontupdate: > >