From owner-cvs-all Thu Aug 1 12:28: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BB5E37B400 for ; Thu, 1 Aug 2002 12:28:00 -0700 (PDT) Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E43A43E4A for ; Thu, 1 Aug 2002 12:27:59 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 18390 invoked from network); 1 Aug 2002 19:27:58 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 1 Aug 2002 19:27:58 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g71JRuuR061651; Thu, 1 Aug 2002 15:27:57 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200208011845.g71IjBXO029595@freefall.freebsd.org> Date: Thu, 01 Aug 2002 15:27:57 -0400 (EDT) From: John Baldwin To: Julian Elischer Subject: RE: cvs commit: src/sys/kern kern_idle.c kern_intr.c kern_sig.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 01-Aug-2002 Julian Elischer wrote: > julian 2002/08/01 11:45:11 PDT > > Modified files: > sys/kern kern_idle.c kern_intr.c kern_sig.c > kern_synch.c > Log: > Slight cleanup of some comments/whitespace. > Make idle process state more consistant. > Add an assert on thread state. > Clean up idleproc/mi_switch() interaction. > Use a local instead of referencing curthread 7 times in a row > (I've been told curthread can be expensive on some architectures) > Remove some commented out code. > Add a little commented out code (completion coming soon) > > Reviewed by: jhb@freebsd.org For the record I reviewed an earlier verison of this and didn't favor the curthread change for the sake of readability for the time being. *shrug* -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message