From owner-svn-src-user@freebsd.org Tue Jan 12 22:55:32 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B6B0A6DB77 for ; Tue, 12 Jan 2016 22:55:32 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E11A8180E; Tue, 12 Jan 2016 22:55:30 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u0CMtULv042991 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 12 Jan 2016 14:55:30 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id u0CMtUU0042990; Tue, 12 Jan 2016 14:55:30 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 12 Jan 2016 14:55:29 -0800 From: Gleb Smirnoff To: Bryan Drewery Cc: Devin Teske , src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r293777 - user/cperciva/freebsd-update-build/scripts Message-ID: <20160112225529.GV1906@FreeBSD.org> References: <201601121806.u0CI67gI009531@repo.freebsd.org> <20160112180805.GP1906@FreeBSD.org> <1452622770.11054.1.camel@FrauBSD.org> <20160112223641.GU1906@FreeBSD.org> <5695813F.9090803@FreeBSD.org> <56958168.8090503@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56958168.8090503@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2016 22:55:32 -0000 On Tue, Jan 12, 2016 at 02:42:48PM -0800, Bryan Drewery wrote: B> On 1/12/16 2:42 PM, Bryan Drewery wrote: B> > On 1/12/16 2:36 PM, Gleb Smirnoff wrote: B> >> On Tue, Jan 12, 2016 at 10:19:30AM -0800, Devin Teske wrote: B> >> D> On Tue, 2016-01-12 at 10:08 -0800, Gleb Smirnoff wrote: B> >> D> > On Tue, Jan 12, 2016 at 06:06:07PM +0000, Gleb Smirnoff wrote: B> >> D> > T> Author: glebius B> >> D> > T> Date: Tue Jan 12 18:06:07 2016 B> >> D> > T> New Revision: 293777 B> >> D> > T> URL: https://svnweb.freebsd.org/changeset/base/293777 B> >> D> > T> B> >> D> > T> Log: B> >> D> > T> Adjust script removing .orig files and empty files: B> >> D> > T> - Adopt the regexp to cleaned patches, that don't have B> >> D> > T> diff or subversion header. B> >> D> > T> - Switch from awk to sed, due to bugs in awk regexps. B> >> D> > B> >> D> > If anyone interested, in our awk regexp "^diff" would match B> >> D> > " diff", any amount of whitespace. Since ntp has a lot B> >> D> > variables named diff, running the script over ntp patches B> >> D> > produce a lot of garbage. B> >> D> > B> >> D> B> >> D> Gleb, I can't seem to reproduce what you're saying. B> >> D> B> >> D> $ echo " diff" | awk '/^diff/' B> >> D> $ echo " diff" | awk '!/^diff/' B> >> D> diff B> >> B> >> echo " diff" | awk '$1 ~ /^diff/ { print $NF }' B> >> B> > B> > That's not a bug. $1 is "diff". B> > B> B> $0 is the whole line: B> B> # echo " blah"|awk '{print $1}' B> blah B> B> # echo " blah"|awk '{print $0}' B> blah Oh, my failure :( -- Totus tuus, Glebius.