Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Feb 2017 16:35:10 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r313164 - stable/11/sys/x86/x86
Message-ID:  <201702031635.v13GZApx073776@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Fri Feb  3 16:35:10 2017
New Revision: 313164
URL: https://svnweb.freebsd.org/changeset/base/313164

Log:
  MFC r312001:
  Remove __nonnull() attributes from x86 machine check architecture.
  
  In this case the attributes serve little purpose as they just don't
  enforce run time checks, If anything the attributes would cause NULL pointer
  checks to be ignored but there are no such checks so the only effect is
  cosmetic.
  
  Reviewed by:	jhb, avg

Modified:
  stable/11/sys/x86/x86/mca.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/x86/x86/mca.c
==============================================================================
--- stable/11/sys/x86/x86/mca.c	Fri Feb  3 16:27:23 2017	(r313163)
+++ stable/11/sys/x86/x86/mca.c	Fri Feb  3 16:35:10 2017	(r313164)
@@ -247,7 +247,7 @@ mca_error_mmtype(uint16_t mca_error)
 	return ("???");
 }
 
-static int __nonnull(1)
+static int
 mca_mute(const struct mca_record *rec)
 {
 
@@ -276,7 +276,7 @@ mca_mute(const struct mca_record *rec)
 }
 
 /* Dump details about a single machine check. */
-static void __nonnull(1)
+static void
 mca_log(const struct mca_record *rec)
 {
 	uint16_t mca_error;
@@ -415,7 +415,7 @@ mca_log(const struct mca_record *rec)
 		printf("MCA: Misc 0x%llx\n", (long long)rec->mr_misc);
 }
 
-static int __nonnull(2)
+static int
 mca_check_status(int bank, struct mca_record *rec)
 {
 	uint64_t status;
@@ -482,7 +482,7 @@ mca_refill(void *context, int pending)
 	mca_fill_freelist();
 }
 
-static void __nonnull(2)
+static void
 mca_record_entry(enum scan_mode mode, const struct mca_record *record)
 {
 	struct mca_internal *rec;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702031635.v13GZApx073776>