Date: Sat, 28 Jun 2008 14:20:36 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Jens Rehsack <rehsack@web.de> Cc: FreeBSD GNOME Users <gnome@freebsd.org>, delphij@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/124115: net/openldap24-server: Auto-Detect OpenLDAP version and modify knobs according to common names Message-ID: <1214677236.86194.7.camel@shumai.marcuscom.com> In-Reply-To: <485E6E98.9000106@web.de> References: <485E6E98.9000106@web.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-eNBZcMKnL2WBlLrtBHt4
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2008-06-22 at 15:24 +0000, Jens Rehsack wrote:
> Hi,
>=20
> I tried a little around with the submitted patch and detected 2 issues:
> 1) I had a typo in line 37 of bsd.ldap.mk
> -DEFAULT_OPENLDPAP_VER?=3D 23
> +DEFAULT_OPENLDAP_VER?=3D 23
> It's quite easy to fix it ;)
>=20
> 2) A port (security/seahorse) checks in line 72 for ${WANT_OPENLDAP_VER},
> which is deprecated. By the way - it doesn't want to check for
> WANT_OPENLDAP_VER, it wants to check for ${OPENLDAP_VER}.
> Doing this would require to split the "code" in bsd.ldap.mk into a
> pre- and post-part, not handle everything in the post-part.
>=20
> What do you think?
I've been away for a week and a half. Has anything come of this? I
have no objection to making seahorse more flexible in terms of LDAP
support if the underlying code supports it.
Joe
--=20
PGP Key : http://www.marcuscom.com/pgp.asc
--=-eNBZcMKnL2WBlLrtBHt4
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEABECAAYFAkhmgPMACgkQb2iPiv4Uz4dxoACfUprJiRxufdIimM0oXbBAEMP8
Pf0AoICNfO9l86hp69Fy74KfY+MWy6Zv
=2tD6
-----END PGP SIGNATURE-----
--=-eNBZcMKnL2WBlLrtBHt4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1214677236.86194.7.camel>