Date: Tue, 16 Mar 2021 22:57:44 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Message-ID: <20210316215744.jksqsyxsqm5254bb@aching.in.mat.cc> In-Reply-To: <1829118.vR5SVPPSqJ@beastie.bionicmutton.org> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225093513.GA59@FreeBSD.org> <20210316021909.GB21936@FreeBSD.org> <1829118.vR5SVPPSqJ@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--fhbhxzlzowfyd2wr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Mar 16, 2021 at 08:59:29PM +0100, Adriaan de Groot wrote:
> On Tuesday, 16 March 2021 03:19:09 CET Alexey Dokuchaev wrote:
> > On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote:
> > > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote:
> > > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote:
> > > > > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL}
> > > > > + # Drop all leading spaces in the script, to minify
> > > > > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL}
> > > >=20
> > > > [[:space:]] works with all versions.
> > >=20
> > > Yes please. Not just it's more robust, it also expresses the intenti=
on
> > > better, as we probably want to trim *any* unnecessary whitespace, not
> > > some particular character.
> >=20
> > So, anything prevents us from going the [[:blank:]] way?
>=20
> So which is it, [[:space:]] or [[:blank:]] ? I don't have much reason to =
prod=20
> at this right now.
=46rom isspace(3) :
=E2=80=9C\t=E2=80=9D =E2=80=9C\n=E2=80=9D =E2=80=9C\v=E2=80=9D =E2=
=80=9C\f=E2=80=9D =E2=80=9C\r=E2=80=9D =E2=80=9C =E2=80=9D
=66rom isblank(3) :
=E2=80=9C\t=E2=80=9D =E2=80=9C =E2=80=9D
--=20
Mathieu Arnold
--fhbhxzlzowfyd2wr
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmBRKdRfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgIpdRAApNMGr4YlSsBtFALgAMu55ngKA5tMK9xADIX0kQoSmw+zmubtKPVDtwL5
IjwgbSHUz3jY7rIcqMcmehn1G8HzAxW+8R/DduZthQbda+H1Av86/nAa6SqY8UOm
KXS7WqbQr6g8bDpxF3He3dBer8pIhNncDB82h6vXAKfCKQ0sVSh4CGMYndqt2PWv
jwIA1GAyYo3D1Evlx3u+S/9rw9qWQKCzsWKa0qaPsPGpKZxleD74jeqx0xaa8a0P
tVCDhiwkWVNuY2M1GPi1CTPtU+plb/x6CtTvTWNuNXEs7p0lxEU3/bdjuraItY2K
1/ih/VMhYfoBxJSF09xX/ona5slUBFC8qayFZ231cFJnlVGp8z6DSZcybSytrM++
o8pxJz0SO+381AKeH+GouBTk3ceDQxSgjfYtkoKg+8VQgYn8BN7jf+CCf4lnOUmH
V+sX9xYRFOinZihiaNkoT7ijDUXlnrPd+xLEWe1h+RfTEhe3n94mxZ45DFzXbOkB
0LS4rFW6deefCSdNvSqYx2bHH8CeM4BjVa6hQSBk1V2P4zpg9xnbIY+UpHpNAY2q
qEPzV/j4DwCDVVjLPvXRvP+5LZUIVImHquXsBZdM0V6yTttOnrSDUlNnNdHY2LZm
CZ9FYNn9uiwGKAq+NagpLWyIDR0rO2B6v37DEqQ0ylz2C340O6A=
=auDZ
-----END PGP SIGNATURE-----
--fhbhxzlzowfyd2wr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210316215744.jksqsyxsqm5254bb>