Date: Thu, 27 Feb 2003 23:12:05 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Will Andrews <will@csociety.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall index.c Message-ID: <20030227211205.GF17255@vega.vega.com> In-Reply-To: <20030227205742.GT37397@procyon.firepipe.net> References: <200302272043.h1RKhq9f048530@repoman.freebsd.org> <20030227205742.GT37397@procyon.firepipe.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 27, 2003 at 12:57:42PM -0800, Will Andrews wrote: > On Thu, Feb 27, 2003 at 12:43:52PM -0800, Maxim Sobolev wrote: > > Log: > > Increase size of the static buffer used to hold runtime dependency list > > read from CD from 2k to 16k, because in the modern world of meta-packages > > (Gnome et al) the length of this list could easily owerflow limit causing > > strange things to happen, ranging from installation failure due to list > > truncation to complete stack trashing (there is very vague bounds checking). > > For example, x11/gnome2-fifth-toe runtime dependencies list is 2,418 bytes > > long. > > Why not do it right the first time? Make it a dynamic buffer > instead of a static one. Because this would mean major rewrite of the code involved - there are static buffers all over the place. Personally, I don't have a time to do, and what is even more important to test, it right now. Feel free, however to pick it up where I left. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030227211205.GF17255>