From owner-svn-src-head@freebsd.org Mon Aug 15 13:16:05 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2CED2BB9F73 for ; Mon, 15 Aug 2016 13:16:05 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt0-x235.google.com (mail-qt0-x235.google.com [IPv6:2607:f8b0:400d:c0d::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8CB21B8B for ; Mon, 15 Aug 2016 13:16:04 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qt0-x235.google.com with SMTP id u25so20786818qtb.1 for ; Mon, 15 Aug 2016 06:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rTotQyaQ+ZvGaAJ60OJ8mn9rowvJG+3s20l8E/eXMec=; b=hRhpntNWeSv9mlYz2ptbe4b44j1cOiLS1IjsLlCFtCfNwvhceWSqHwS5ApeGJ5U0Zm cyCBqjarE6hPqFIEJw5xND6rBKmRFO+SShhdQyDH36PzMhFbmWIWbRWSlSxbFLdveAt7 seFOGMiI21JcrygOWBcpKCLOxwQEJ+UWD3mD4alxMTiEnCOKxYZJTIRjBmCOV54rV3/I RDQGjIlcXJRtcx9FfNal3+l06AOWSGVjZEqE+ltkJRDmDDXiL1sNiiEmz0bVM10OwN/o ZFRA3cAolc9mNnX0nuXB4ep4E+vViw4hfRpqfhf1xfynGaDyHltC3frK6i7PPuyScUSA gdYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rTotQyaQ+ZvGaAJ60OJ8mn9rowvJG+3s20l8E/eXMec=; b=ko/QngwWnlBh+EZum3xBwReHWdpOWOGkCYXREu+ep+i+PsxvGsvthNDlvcrZ9grmMr zVy7wEgWUhrUj2L7v+WZBt0bseSy487c8j9G3mzIS8Jm3fYquH120Q/viRUZWOmqOn9o s8vIAZ3ZAZooPgzep0trjEH6O505v4arZCUYV+uksN5Q8YPzu9L90tNb7GPonTY9QHMl VIu5CYOTYMjV7a7cA3I+vvZPfxx1P2Ridthy3iH+9cekJGGVl4zMSAs6xZSXxovV+T3s /VOoAQwWxGg5lpBV2bpxvRX6haBw1CjRTvmetikvE5NpSAuvoKgPMHIb5V3/uHX7XKKf KM7w== X-Gm-Message-State: AEkoouusBvUTo6GPf925KhPYizhzCd3gXAFY2hhG4JJ+f2iMdbeJePMsacaJHOBpy+vz1h1w X-Received: by 10.200.43.105 with SMTP id 38mr32459868qtv.73.1471266963940; Mon, 15 Aug 2016 06:16:03 -0700 (PDT) Received: from mutt-hardenedbsd (pool-100-16-219-226.bltmmd.fios.verizon.net. [100.16.219.226]) by smtp.gmail.com with ESMTPSA id w184sm11013537qkw.38.2016.08.15.06.16.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Aug 2016 06:16:02 -0700 (PDT) Date: Mon, 15 Aug 2016 09:16:00 -0400 From: Shawn Webb To: Bruce Evans Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304153 - head/sys/dev/syscons Message-ID: <20160815131600.GA86798@mutt-hardenedbsd> References: <201608151256.u7FCujHw048832@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <201608151256.u7FCujHw048832@repo.freebsd.org> X-Operating-System: FreeBSD mutt-hardenedbsd 12.0-CURRENT-HBSD FreeBSD 12.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2016 13:16:05 -0000 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2016 at 12:56:45PM +0000, Bruce Evans wrote: > Author: bde > Date: Mon Aug 15 12:56:45 2016 > New Revision: 304153 > URL: https://svnweb.freebsd.org/changeset/base/304153 >=20 > Log: > Quick fix for locking fixes in r172250. The lock added there was per- > virtual-device, but needs to be per-physical-device so that it protects > shared data. Usually, scp->sc->write_in_progress got corrupted first > and further corruption was limited when this variable was left at nonze= ro > with no write in progress. > =20 > Attempt to fix missing lock destruction in r162285. Put it with the > lock destruction for r172250 after moving the latter. Both might be > unreachable. > =20 > To demonstrate the bug, find a buggy syscall or sysctl that calls > printf(9) and run this often. Run hd /dev/zero >/dev/ttyvN for any > N !=3D 0. The console spam goes to ttyv0 and the non-console spam goes > to ttyvN, so the lock provided no protection (but it helped for > N =3D=3D 0). >=20 Hey Bruce, Should this be MFC'd after some point? Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXscCMAAoJEGqEZY9SRW7uxugP/iMpq3pF0akMPnu0Jf/WyuHw CGNCn2bCde1OP0PHUG0u+zkD5ri0N5r2wPanQtbKpw4fS+5SZB0iSnus21BhzUb0 vGkUrfe8TRv0IWwDW5JRa6dFqs5mW7WA+4YpVxH8huarJ00GGyKVpFuSUEPmURHR kCXswD8bx9J4b16myW/wpBv5nvRwtJ5bGoRszDnG/Stk3DMnSRlTYiHr6Wfgi7dz jbHrH4OzdOz9WXzN+JsQ3SOnyX1ruCVzsidLflzdB8O4PXtdB5khewQnSTUiltY4 P5nPpx6drQKCaZeCI+ZnIzc4VScxRaP67YOIgES4EZAtQ310+HoWqWkhIUDcdC6D qDnG71nHiuhhzEyJBKVY2FO+9pLr6e1q0ecDrouv9D2J6O3s2fh8Tmnds+ONRMe/ pNZr5r2QukATM+0NSZSQtF9yVpO+dcFda9neDI6wIWj3Dfx2Tyh3K5LNiioUC3hJ MvYmpYwcwi3dj1GPJXVlDxEusk0n+4w3uOMwXihfwSlK23soVourL1SyvlaEazUd +knWqHKaWQxaytBr/f9KPXEuJ9GsSLu/jv4NdbekocrDFNv1Zv7YyAEkRBj2RsQD 9EzCmbBbqiUNha8Bv9GKPBxOLVTEywwU57my4nznqqpUTT2NtqUDAKATOchvM0zM RHdM/geV/5MhW7IkizzJ =s/uo -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--