From owner-cvs-all@FreeBSD.ORG  Fri Jun  4 08:13:52 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B9AA416A4CE; Fri,  4 Jun 2004 08:13:52 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C54A143D2D; Fri,  4 Jun 2004 08:13:51 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i54FDoop017970;
	Fri, 4 Jun 2004 17:13:50 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: John Baldwin <jhb@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 04 Jun 2004 11:12:28 EDT."
             <200406041112.28276.jhb@FreeBSD.org> 
Date: Fri, 04 Jun 2004 17:13:50 +0200
Message-ID: <17969.1086362030@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/i386/include/pc bios.h src/sys/i386/i386
	bios.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2004 15:13:53 -0000

In message <200406041112.28276.jhb@FreeBSD.org>, John Baldwin writes:

>> >It this very different from bios_sigsearch()?
>>
>> It is not limited to the system bios (0xe0000..0xfffff) but allows you
>> to specify the exact range you're interested in.
>
>Perhaps one should be implemented in terms of the other then?  Hmm, you can 
>probably use this to replace 'search_for_sig()' in mptable.c as well.

I'm certainly not against merging the various stuff.

On the other hand we're talking 10 line functions, I'm not sure that
generalizing is warranted.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.