From owner-svn-src-all@freebsd.org Wed Oct 16 18:13:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE9DD14CD5E for ; Wed, 16 Oct 2019 18:13:23 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46tgQW0cYDz46Q4 for ; Wed, 16 Oct 2019 18:13:22 +0000 (UTC) (envelope-from ricera10@gmail.com) Received: by mail-lf1-f54.google.com with SMTP id r22so18296837lfm.1 for ; Wed, 16 Oct 2019 11:13:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LwiWBOXYemwUGNVr61w4b344GNn/hEnbr88nhG12qTY=; b=F9bRw+F80STjX3zPSjwNPQl4BdyKekNiDBDl0mwE0uPGW1osfLCRwfHg06y6d27hQX Yd86FfGOl8ccOWEcW8lLsCVxsYmJDEm3CuA48WRcaw0JuDbxNFy2d1Akc6eMrHBlYPzx TbM5IsAEgXBsHrzJbLLEOJyJGktkpAWmTTpQnbR0gIuK1LscE0yV0gOLPbl5Vq9TUJIW 93+eC5djeT3NGKH+pqx/CR3xo+A1Htopt5vzB0WYmhBABgJhLdP7WD28oPjs50t0w7gI yM5Snwg6+fftv/J5ZL3wITOntJxea+8+/tf7JqKAyoH1hOj8Y7z5AwRfMVztI4JzIMRH z6bw== X-Gm-Message-State: APjAAAXyDZjbdb0Mnv1IKqQnXHh8azSb9tFlioF9pes0zNjrmje7qmAb BIounFqXuXtjFiyEkE3xQKoOP6Jf X-Google-Smtp-Source: APXvYqw8kaPO4DftxZ3QkuL70Xdo5vrmSmpPyvx1chy1Cfc37xug3eJ2MEDh14N0dBOkbcTWKzQbjw== X-Received: by 2002:a19:4b8f:: with SMTP id y137mr26357277lfa.19.1571249600801; Wed, 16 Oct 2019 11:13:20 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id g3sm6497484ljj.59.2019.10.16.11.13.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 11:13:20 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id d1so24933434ljl.13 for ; Wed, 16 Oct 2019 11:13:19 -0700 (PDT) X-Received: by 2002:a2e:99cc:: with SMTP id l12mr25857724ljj.175.1571249599464; Wed, 16 Oct 2019 11:13:19 -0700 (PDT) MIME-Version: 1.0 References: <201910161719.x9GHJHux068505@repo.freebsd.org> <20191016194359.2c1cddf2@thor.intern.walstatt.dynvpn.de> In-Reply-To: <20191016194359.2c1cddf2@thor.intern.walstatt.dynvpn.de> From: Eric Joyner Date: Wed, 16 Oct 2019 11:13:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r353658 - head/sys/dev/ixl To: "O. Hartmann" Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 46tgQW0cYDz46Q4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ricera10@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=ricera10@gmail.com X-Spamd-Result: default: False [-2.19 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; URI_COUNT_ODD(1.00)[9]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[54.167.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.19)[ip: (-0.56), ipnet: 209.85.128.0/17(-3.24), asn: 15169(-2.10), country: US(-0.05)]; FORGED_SENDER(0.30)[erj@freebsd.org,ricera10@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[54.167.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[erj@freebsd.org,ricera10@gmail.com]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Oct 2019 18:13:23 -0000 Does r353661 fix it? I didn't catch "adapter" being used, probably due to committing patches for the other drivers that do use "adapter". On Wed, Oct 16, 2019 at 10:57 AM O. Hartmann wrote= : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am Wed, 16 Oct 2019 17:19:17 +0000 (UTC) > Eric Joyner schrieb: > > > Author: erj > > Date: Wed Oct 16 17:19:17 2019 > > New Revision: 353658 > > URL: https://svnweb.freebsd.org/changeset/base/353658 > > > > Log: > > ixl: report whether device received pause frames > > > > From Jake: > > When updating the device statistics, report whether or not we have > > received any pause frames to the iflib stack. This allows the iflib > > stack to avoid generating a Tx hang message while the device is pause= d. > > > > Signed-off-by: Jacob Keller > > > > Submitted by: Jacob Keller > > Reviewed by: gallatin@ > > Sponsored by: Intel Corporation > > Differential Revision: https://reviews.freebsd.org/D21870 > > > > Modified: > > head/sys/dev/ixl/ixl_pf_main.c > > > > Modified: head/sys/dev/ixl/ixl_pf_main.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/sys/dev/ixl/ixl_pf_main.c Wed Oct 16 17:16:32 2019 > (r353657) > > +++ head/sys/dev/ixl/ixl_pf_main.c Wed Oct 16 17:19:17 2019 > (r353658) > > @@ -2592,6 +2592,7 @@ ixl_update_stats_counters(struct ixl_pf *pf) > > struct i40e_hw *hw =3D &pf->hw; > > struct ixl_vsi *vsi =3D &pf->vsi; > > struct ixl_vf *vf; > > + u64 prev_link_xoff_rx =3D pf->stats.link_xoff_rx; > > > > struct i40e_hw_port_stats *nsd =3D &pf->stats; > > struct i40e_hw_port_stats *osd =3D &pf->stats_offsets; > > @@ -2676,6 +2677,13 @@ ixl_update_stats_counters(struct ixl_pf *pf) > > ixl_stat_update32(hw, I40E_GLPRT_LXOFFTXC(hw->port), > > pf->stat_offsets_loaded, > > &osd->link_xoff_tx, &nsd->link_xoff_tx); > > + > > + /* > > + * For watchdog management we need to know if we have been paused > > + * during the last interval, so capture that here. > > + */ > > + if (pf->stats.link_xoff_rx !=3D prev_link_xoff_rx) > > + adapter->shared->isc_pause_frames =3D 1; > > > > /* Packet size stats rx */ > > ixl_stat_update48(hw, I40E_GLPRT_PRC64H(hw->port), > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > This commit renders buildkernel to fail: > > [...] > - --- ixl_pf_main.o --- > /usr/src/sys/dev/ixl/ixl_pf_main.c:2686:3: error: use of undeclared > identifier 'adapter' > adapter->shared->isc_pause_frames =3D 1; > > > - -- > O. Hartmann > > Ich widerspreche der Nutzung oder =C3=9Cbermittlung meiner Daten f=C3=BCr > Werbezwecke oder f=C3=BCr die Markt- oder Meinungsforschung (=C2=A7 28 Ab= s. 4 BDSG). > -----BEGIN PGP SIGNATURE----- > > iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCXadW3wAKCRA4N1ZZPba5 > R3dtAP9HZKlb9tPUVxUJvM+5TsLS77I/4wGFKhAv8BvOQrWatwD+JIznJtN5S1lw > C0dXiqrWuv/WYi01X4zWnGUOS0DoMgs=3D > =3DErFZ > -----END PGP SIGNATURE----- >