Date: Wed, 7 Feb 2007 07:04:14 -0800 From: Bill Fenner <fenner@research.att.com> To: "Bruce M. Simpson" <bms@freebsd.org> Cc: net@freebsd.org Subject: Re: Proposal: remove encap from MROUTING Message-ID: <200702071504.l17F4EJx001944@bright.research.att.com> References: <45C39CBF.7010105@incunabulum.net> <45C94116.3090404@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>I plan to commit this patch some time this week. >---mroute-notunnels.diff, text/x-patch follows--- Please do. Only one comment: >@@ -859,8 +816,6 @@ X_ip_mrouter_done(void) > /* > * Reset de-encapsulation cache > */ >- last_encap_src = INADDR_ANY; >- last_encap_vif = NULL; > #ifdef PIM > reg_vif_num = VIFI_INVALID; > #endif I think that comment goes with the removed lines so should be removed with them. While you're thinking about removing stuff, think about removing the tbf code next. There are way more flexible ways of rate limiting traffic in the base system, so the tbf hack can and should just die. Just return an error when trying to create a vif with a rate limit. Bill
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702071504.l17F4EJx001944>