Date: Wed, 21 Aug 2002 17:11:16 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: Archie Cobbs <archie@dellroad.org> Cc: "M. Warner Losh" <imp@bsdimp.com>, freebsd-arch@FreeBSD.ORG Subject: Re: NULL Message-ID: <20020822001115.GA45577@dragon.nuxi.com> In-Reply-To: <200208212322.g7LNMcc08044@arch20m.dellroad.org> References: <20020821.003628.52042275.imp@bsdimp.com> <200208212322.g7LNMcc08044@arch20m.dellroad.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 21, 2002 at 04:22:38PM -0700, Archie Cobbs wrote: > M. Warner Losh writes: > > In message: <200208210323.g7L3NTR04362@arch20m.dellroad.org> > > Archie Cobbs <archie@dellroad.org> writes: > > : So my vote is for NULL = "((void *)0)" when compiling C code > > : (and leaving "0" when compiling C++, which can easily be different). > > > > That leaves just 7 files to ifdef. Well, 9 files from the egrep: > > The patch makes 'make buildworld' and 'make buildkernel KERNCONF=LINT' > work for me; fyi I have "NO_WERROR= YES" in /etc/make.conf. > > Does anyone have an objection to this patch? Yes -- only because you haven't tested with the defaults of not having NO_WERROR=YES. I.e., if you commit this patch you really don't know if you will be breaking the world for the rest of us. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020822001115.GA45577>