From owner-freebsd-arch Wed Aug 21 17:11:39 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD75B37B400 for ; Wed, 21 Aug 2002 17:11:36 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 597BA43E4A for ; Wed, 21 Aug 2002 17:11:36 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.5/8.12.2) with ESMTP id g7M0BH27045622; Wed, 21 Aug 2002 17:11:17 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.5/8.12.5/Submit) id g7M0BGmp045621; Wed, 21 Aug 2002 17:11:16 -0700 (PDT) Date: Wed, 21 Aug 2002 17:11:16 -0700 From: "David O'Brien" To: Archie Cobbs Cc: "M. Warner Losh" , freebsd-arch@FreeBSD.ORG Subject: Re: NULL Message-ID: <20020822001115.GA45577@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: <20020821.003628.52042275.imp@bsdimp.com> <200208212322.g7LNMcc08044@arch20m.dellroad.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200208212322.g7LNMcc08044@arch20m.dellroad.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Aug 21, 2002 at 04:22:38PM -0700, Archie Cobbs wrote: > M. Warner Losh writes: > > In message: <200208210323.g7L3NTR04362@arch20m.dellroad.org> > > Archie Cobbs writes: > > : So my vote is for NULL = "((void *)0)" when compiling C code > > : (and leaving "0" when compiling C++, which can easily be different). > > > > That leaves just 7 files to ifdef. Well, 9 files from the egrep: > > The patch makes 'make buildworld' and 'make buildkernel KERNCONF=LINT' > work for me; fyi I have "NO_WERROR= YES" in /etc/make.conf. > > Does anyone have an objection to this patch? Yes -- only because you haven't tested with the defaults of not having NO_WERROR=YES. I.e., if you commit this patch you really don't know if you will be breaking the world for the rest of us. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message