From owner-freebsd-audit  Fri Jun 22  3:32: 4 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C81A37B401; Fri, 22 Jun 2001 03:32:02 -0700 (PDT)
	(envelope-from obrien@nuxi.ucdavis.edu)
Received: from dragon.nuxi.com (root@trang.nuxi.com [206.40.252.115])
	by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f5MAW1R14297;
	Fri, 22 Jun 2001 03:32:01 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f5MAW1t00776;
	Fri, 22 Jun 2001 03:32:01 -0700 (PDT)
	(envelope-from obrien)
Date: Fri, 22 Jun 2001 03:32:01 -0700
From: "David O'Brien" <obrien@freebsd.org>
To: Mike Barcroft <mike@q9media.com>
Cc: Mike Heffner <mheffner@vt.edu>, phk@freebsd.org,
	freebsd-audit@freebsd.org
Subject: Re: whois(1) patch
Message-ID: <20010622033201.B506@dragon.nuxi.com>
Reply-To: obrien@freebsd.org
References: <XFMail.20010530223446.mheffner@novacoxmail.com> <B73C05FD.BD5%mike@q9media.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <B73C05FD.BD5%mike@q9media.com>; from mike@q9media.com on Thu, May 31, 2001 at 02:30:21PM -0400
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Thu, May 31, 2001 at 02:30:21PM -0400, Mike Barcroft wrote:
> > | It does the following:
> > | 
> > |  o Silence warnings and set WARNS=2
> > |  o Fix two memory leaks
> > |  o asprint -> strdup where appropriate
> > |  o calloc/strcpy/strcat -> aprintf
> > |  o Convert to ANSI C to avoid having to prototype main()


You should separate your patches into functionality and style(9).
I see DES just committed this patch as is, rather than break it into two
parts as our practices says it should have been.

You also changed puts() to printf().  Was there a reason for making that
change?

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message