Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Sep 1995 03:07:52 -0700
From:      asami@cs.berkeley.edu (Satoshi Asami)
To:        jmz@cabri.obs-besancon.fr
Cc:        rgrimes@gndrsh.aac.dev.com, CVS-commiters@freefall.freebsd.org, cvs-ports@freefall.freebsd.org
Subject:   Re: cvs commit: ports/utils/ispell/scripts configure
Message-ID:  <199509191007.DAA01264@silvia.HIP.Berkeley.EDU>
In-Reply-To: <9509190407.AA26129@cabri.obs-besancon.fr> (message from Jean-Marc Zucconi on Tue, 19 Sep 95 05:07:59 %2B0100)

next in thread | previous in thread | raw e-mail | index | archive | help
 *  >> Modified:    utils/ispell/scripts  configure
 *  >> Log:
 *  >> Compile with -O2 -fno-strength-reduce

 * This is not always possible. In this case, CFLAGS was hardcoded in a
 * file (and the flags need to be between quotes). 

But this is the configure script, there are many ways to pass the
CFLAGS picked up from /etc/make.conf.  Don't forget the make that's
running scripts/configure knows about it already.

One way is to modify bsd.port.mk to pass CFLAGS to the configure
script in the scripts/ dir as well (not only the one in $WRKSRC/).
Probably this should be done anyway, the assymmetry of the invocation
mechanisms of $SCRIPTDIR/configure and $WRKSRC/configure has amused me 
quite a bit in the past.

Or we can do something like:

=======
Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/utils/ispell/Makefile,v
retrieving revision 1.9
diff -u -r1.9 Makefile
--- 1.9	1995/07/21 13:22:04
+++ Makefile	1995/09/19 10:01:31
@@ -37,6 +37,9 @@
 	@echo -n
 .endif
 
+post-configure:
+	@echo "#define CFLAGS \"${CFLAGS}\"" >> ${WRKSRC}/local.h
+
 british:
 	@echo "Okay, making a british version of ispell...."
 	@${MAKE} ${.MAKEFLAGS} LANG=british all 
Index: scripts/configure
===================================================================
RCS file: /usr/cvs/ports/utils/ispell/scripts/configure,v
retrieving revision 1.8
diff -u -r1.8 configure
--- 1.8	1995/09/18 23:36:43
+++ configure	1995/09/19 10:00:19
@@ -41,7 +41,6 @@
 echo '#define WORDS   "/usr/share/dict/words"'  >> local.h 
 echo '#undef ELISPDIR'  >> local.h
 echo "#define ELISPDIR \"$PREFIX/share/emacs/site-lisp\"" >> local.h
-echo '#define CFLAGS "-O2 -fno-strength-reduce"' >>local.h
 
 mv Makefile Makefile.orig
 sed -e 's/^[ 	]*$/\
=======

(Just tested, it works here. :)

Satoshi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509191007.DAA01264>