Date: Tue, 10 Mar 2015 11:11:38 +0000 From: "mav (Alexnder Motin)" <phabric-noreply@FreeBSD.org> To: freebsd-arm@freebsd.org Subject: [Differential] [Commented On] D2018: Introduce Annapurna Labs AHCI support Message-ID: <d0c99d694325728cecaec47aa03b63e7@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org> References: <differential-rev-PHID-DREV-lp4daqpuzz2y5vyrxipd-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
mav added inline comments. INLINE COMMENTS sys/dev/ahci/ahci.c:150-153 AHCI specification defines this register as read-only. It tells nothing about "restoring" this register. I don't like idea of writing to read-only registers. sys/dev/ahci/ahci.c:199-201 According to specification, this is something that platform/BIOS must set. I know that Linux sets it always, but I believe that this is spec violation. If there is some BROKEN hardware that require it to be set by the driver, I can accept hardware-specific quirk or some tunable, but not global. REVISION DETAIL https://reviews.freebsd.org/D2018 To: zbb, mav, imp, smh Cc: freebsd-arm
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d0c99d694325728cecaec47aa03b63e7>