From owner-cvs-all@FreeBSD.ORG  Fri Sep 22 13:48:02 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2E98E16A407;
	Fri, 22 Sep 2006 13:48:02 +0000 (UTC)
	(envelope-from tataz@tataz.chchile.org)
Received: from smtp2-g19.free.fr (smtp2-g19.free.fr [212.27.42.28])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B7BEF43D45;
	Fri, 22 Sep 2006 13:48:01 +0000 (GMT)
	(envelope-from tataz@tataz.chchile.org)
Received: from tatooine.tataz.chchile.org (tataz.chchile.org [82.233.239.98])
	by smtp2-g19.free.fr (Postfix) with ESMTP id E6C67754EA;
	Fri, 22 Sep 2006 15:48:00 +0200 (CEST)
Received: from obiwan.tataz.chchile.org (unknown [192.168.1.25])
	by tatooine.tataz.chchile.org (Postfix) with ESMTP id 91E509B4C1;
	Fri, 22 Sep 2006 13:48:06 +0000 (UTC)
Received: by obiwan.tataz.chchile.org (Postfix, from userid 1000)
	id 7273D408C; Fri, 22 Sep 2006 15:48:06 +0200 (CEST)
Date: Fri, 22 Sep 2006 15:48:06 +0200
From: Jeremie Le Hen <jeremie@le-hen.org>
To: Matteo Riondato <matteo@FreeBSD.org>
Message-ID: <20060922134806.GU15761@obiwan.tataz.chchile.org>
References: <200605301620.k4UGKnOf023961@repoman.freebsd.org>
	<20060922132258.GA26411@obiwan.tataz.chchile.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060922132258.GA26411@obiwan.tataz.chchile.org>
User-Agent: Mutt/1.5.12-2006-07-14
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: [fbsd] cvs commit [HEAD] src/etc/rc.d jail src/etc/defaults
	rc.conf src/share/man/man5 rc.conf.5
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2006 13:48:02 -0000

Matteo,

On Tue, May 30, 2006 at 04:20:48PM +0000, Matteo Riondato wrote:
> matteo      2006-05-30 16:20:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             jail 
>     etc/defaults         rc.conf 
>     share/man/man5       rc.conf.5 
>   Log:
>   Add jail_<jname>_exec_afterstart<N> rc.conf variable, where <N> is
>   1,2 and so on.
>   It specifies the command to be run as Nth after jail startup.
>   
>   sh(1)-fu by: Dario Freni
>   PR:     conf/97697
>   MFC after: 2 weeks
>   Reviewed by: ru@ (man page)

The variable name as well as the manpage is IMHO misleading.  I thought
the command was executed on the host, not inside the jail.

I daresay the name should have been something like:
jail_<jname>_jexec_afterstart<N>.  But we would have lost
name consistency with jail_<jname>_exec_start.

We should at least fix the documentation:

Index: rc.conf.5
===================================================================
RCS file: /home/ncvs/src/share/man/man5/rc.conf.5,v
retrieving revision 1.306
diff -u -p -u -r1.306 rc.conf.5
--- rc.conf.5   18 Sep 2006 15:24:20 -0000      1.306
+++ rc.conf.5   22 Sep 2006 13:47:15 -0000
@@ -3209,7 +3209,7 @@ This is the command executed at jail sta
 .It Va jail_ Ns Ao Ar jname Ac Ns Va _exec_afterstart Ns Aq Ar N
 .Pq Vt str
 Unset by default.
-This is the command run as
+This is the command run inside the jail as
 .Ar N Ns
 th command
 after jail startup, where



Thank you.  Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >