From owner-freebsd-geom@FreeBSD.ORG Sun Nov 30 23:32:56 2008 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D7FD106564A for ; Sun, 30 Nov 2008 23:32:56 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: from kiwi-computer.com (keira.kiwi-computer.com [63.224.10.3]) by mx1.freebsd.org (Postfix) with SMTP id B82418FC16 for ; Sun, 30 Nov 2008 23:32:55 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: (qmail 27691 invoked by uid 2001); 30 Nov 2008 23:32:55 -0000 Date: Sun, 30 Nov 2008 17:32:55 -0600 From: "Rick C. Petty" To: freebsd-geom@freebsd.org Message-ID: <20081130233255.GA27667@keira.kiwi-computer.com> References: <20081130225805.GA27328@keira.kiwi-computer.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081130225805.GA27328@keira.kiwi-computer.com> User-Agent: Mutt/1.4.2.3i Subject: Re: (trivial) patch to add provider name to printed warning X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: rick-freebsd2008@kiwi-computer.com List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2008 23:32:56 -0000 On Sun, Nov 30, 2008 at 04:58:05PM -0600, Rick C. Petty wrote: > Could someone with a commit bit (perhaps phk@) look at the following > trivial patch? It can't hurt anything, since the provider name cannot > be NULL here. Thanks, D'oh, the attachment was filtered. Here it is inline... -- Rick C. Petty --- src/sys/geom/geom_bsd.c.orig 2007-12-17 19:24:27.000000000 -0600 +++ src/sys/geom/geom_bsd.c 2008-11-30 03:09:04.000000000 -0600 @@ -136,7 +136,8 @@ } if (rawoffset != 0 && (off_t)rawoffset != ms->mbroffset) - printf("WARNING: Expected rawoffset %jd, found %jd\n", + printf("WARNING: %s expected rawoffset %jd, found %jd\n", + gp->name, (intmax_t)ms->mbroffset/dl.d_secsize, (intmax_t)rawoffset/dl.d_secsize);