Date: Mon, 28 Jan 2013 13:53:36 -0500 From: John Baldwin <jhb@freebsd.org> To: Chagin Dmitry <chagin.dmitry@gmail.com> Cc: emulation@freebsd.org Subject: Re: [PATCH] Move MI bits out of MD linux.h Message-ID: <201301281353.36994.jhb@freebsd.org> In-Reply-To: <20130128174944.GA4105@dchagin.static.corbina.net> References: <201301280947.39690.jhb@freebsd.org> <20130128174944.GA4105@dchagin.static.corbina.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, January 28, 2013 12:49:44 pm Chagin Dmitry wrote: > On Mon, Jan 28, 2013 at 09:47:39AM -0500, John Baldwin wrote: > > This patch attempts to reduce duplication between i386/linux/linux.h and > > amd64/linux32/linux.h by moving bits that are MI out into headers in > > compat/linux. I only moved constants that were defined in MI headers in Linux > > itself, not necessarily all constants that have the same value. Further > > reduction could be possible if we wanted to make a linux-i386.h that these two > > headers could share, but that would be a separate project. > > > > http://www.FreeBSD.org/~jhb/patches/linux_mi.patch > > > > Hi, John! > Looks ok to me, furthemore I have similar patches in the local x86_64 linuxulator > repo. So, commit, please. So do you have an open PR with patches for the 64-bit linux stuff? I'd like to look at what you have and see about getting it into the tree if so. I'm curious about how you handled things (e.g. do you recompile things like linux_file.c twice once as 32-bit once as native, and do you have linux32.ko for the existing module and linux.ko for 64-bit)? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301281353.36994.jhb>