Date: Sat, 26 Aug 2006 15:30:29 +1200 From: Andrew Thompson <thompsa@freebsd.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org, Guido van Rooij <guido@gvr.org>, Alexander Kabaev <kabaev@gmail.com> Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... Message-ID: <20060826033029.GB80099@heff.fud.org.nz> In-Reply-To: <20060826023120.GA74468@troutmask.apl.washington.edu> References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824092002.44b90594@kan.dnsalias.net> <20060824133628.GA54467@gvr.gvr.org> <20060824101606.414e8bf6@kan.dnsalias.net> <20060824205854.GA59856@gvr.gvr.org> <20060824184402.2ee29d79@kan.dnsalias.net> <20060826020854.GD16768@turion.vk2pj.dyndns.org> <20060826023120.GA74468@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 25, 2006 at 07:31:20PM -0700, Steve Kargl wrote: > On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote: > > On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote: > > >personally. The mistake you made just shows how important it is to do a > > >buildworld _from freshly checked out sources_ after every major vendor > > >import. > > > > I'm not sure how doing this would have prevented the breakage. It > > might have allowed Guido to notice the breakage more quickly. > > > Doing a fresh checkout and a "make universe" > > (since "make buildworld" is not always sufficient to catch breakage) > > may not have been that much faster. > > Huh? If Guido had done a "make buildworld" or "make universe" > before he committed the source, then the problem would never have > existed. Thats not true in this case. The problem was that a new file hadnt been cvs added, the file was sitting in his tree so it built correctly, no amount of "make buildworld" or "make universe" would have caught that, let it go. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060826033029.GB80099>