Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Aug 2008 05:04:33 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Martin Wilke <miwi@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/Mk bsd.qt.mk ports/devel Makefile ports/multimedia Makefile ports/textproc Makefile ports/www Makefile ports/accessibility/qt4-accessible Makefile distinfo ports/chinese/qt4-codecs-cn Makefile distinfo pkg-plist ...
Message-ID:  <20080805050433.GA31566@FreeBSD.org>
In-Reply-To: <200808042330.m74NUd9C071984@repoman.freebsd.org>
References:  <200808042330.m74NUd9C071984@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 04, 2008 at 11:30:39PM +0000, Martin Wilke wrote:
>   Log:
>   - Update to qt 4.4.1

Hi Martin,

I haven're reviewed each and every change (it's obviously too much of
them ;-) but at least ports/x11/qt4-opengl/Makefile looks strange: it
seems you somehow restored USE_GL=yes and USE_XLIB=yes instead of
fine-grained values like glu for GL and specific XORG compoments?  Is it
intentional?

You could have also just removed PORTREVISION line instead of reseting
it to zero.

Thanks.  I will answer your previous mail shortly.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080805050433.GA31566>