Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 20 Dec 2017 13:07:22 -0700
From:      Ian Lepore <ian@freebsd.org>
To:        John Baldwin <jhb@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r326991 - in head/sys/fs: nfs nfsclient
Message-ID:  <1513800442.29087.28.camel@freebsd.org>
In-Reply-To: <201712191918.vBJJImA5072223@repo.freebsd.org>
References:  <201712191918.vBJJImA5072223@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2017-12-19 at 19:18 +0000, John Baldwin wrote:
> Author: jhb
> Date: Tue Dec 19 19:18:48 2017
> New Revision: 326991
> URL: https://svnweb.freebsd.org/changeset/base/326991
> 
> Log:
>   Update NFS to handle larger link counts post ino64.
> 
[...]
> Modified: head/sys/fs/nfsclient/nfs_clvnops.c
> ==============================================================================
> --- head/sys/fs/nfsclient/nfs_clvnops.c	Tue Dec 19 19:14:01 2017	(r326990)
> +++ head/sys/fs/nfsclient/nfs_clvnops.c	Tue Dec 19 19:18:48 2017	(r326991)
> @@ -3450,7 +3450,7 @@ nfs_pathconf(struct vop_pathconf_args *ap)
>  		 * For NFSv2 (or NFSv3 when not one of the above 4 a_names),
>  		 * just fake them.
>  		 */
> -		pc.pc_linkmax = LINK_MAX;
> +		pc.pc_linkmax = NFS_LINK_MAX;
>  		pc.pc_namemax = NFS_MAXNAMLEN;
>  		pc.pc_notrunc = 1;
>  		pc.pc_chownrestricted = 1;
> @@ -3460,7 +3460,7 @@ nfs_pathconf(struct vop_pathconf_args *ap)
>  	}
>  	switch (ap->a_name) {
>  	case _PC_LINK_MAX:
> -		*ap->a_retval = pc.pc_linkmax;
> +		*ap->a_retval = MIN(LONG_MAX, pc.pc_linkmax);

I just noticed a build error on powerpc LINT and LINT64 kernels on this
line:

/b/staging/freebsd/head/src/sys/fs/nfsclient/nfs_clvnops.c:3464:
warning: comparison is always false due to limited range of data type

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1513800442.29087.28.camel>