From owner-freebsd-ports@freebsd.org Sat Dec 5 17:03:00 2015 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A8BFA42D5C for ; Sat, 5 Dec 2015 17:03:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 80E8C1E23; Sat, 5 Dec 2015 17:03:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 7ABBB1DB3; Sat, 5 Dec 2015 17:03:00 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 329D11789D; Sat, 5 Dec 2015 17:03:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id GjA_UW3C3Q1H; Sat, 5 Dec 2015 17:02:57 +0000 (UTC) Subject: Re: MAKEFLAGS caused temporary insanity DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 3E7F917891 To: Jan Beich References: <5662376C.8090809@FreeBSD.org> Cc: Euan Thoms , FreeBSD Ports Mailing List From: Bryan Drewery Organization: FreeBSD Message-ID: <566318BF.2030104@FreeBSD.org> Date: Sat, 5 Dec 2015 09:02:55 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2015 17:03:00 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 12/5/15 1:09 AM, Jan Beich wrote: > Bryan Drewery writes: > >> On 11/24/2015 8:00 PM, Euan Thoms wrote: >> >>> >>> On Tuesday, November 24, 2015 11:15 SGT, Jan Beich >>> wrote: >>> >>>> "Euan Thoms" writes: >>>> >>>>> do-build: cd ${WRKSRC} && unset MAKEFLAGS && >>>>> ${OPENSIPS_MAKE_ENV} ${GMAKE} ${_MAKE_JOBS} ${ALL_TARGET} >>>> >>>> Have you tried defining NOPRECIOUSMAKEVARS in the port's >>>> Makefile? >>>> >>> >>> That did the trick, thanks. I can now remove the "unset >>> MAKEFLAGS" in do-build. >>> >>> >> >> As far as I can tell NOPRECIOUSMAKEVARS does not impact the >> variable literally named 'MAKEFLAGS'. It should only be impacting >> these: >> >> # make -V _EXPORTED_VARS ARCH OPSYS _OSRELEASE OSREL OSVERSION >> _PKG_CHECKED HAVE_COMPAT_IA32_KERN _SMP_CPUS >> CONFIGURE_MAX_CMD_LEN > > Did you read my reply untrimmed? net/opensips uses ARCH in vendor > Makefile This is what I was looking for. > and the framework clobbers its value. Some ports like > multimedia/ffmpeg rename the variable, others give up and define > NOPRECIOUSMAKEVARS. > >> Which port was this? Which release are you running (real question >> is whether it was fmake or bmake)? > > Affects both. I did propose 2 ways to fix. > The real fix would be to not export these to the port builds. We experimented with using 'env -i' in the build a few years back and had a lot of fallout. - -- Regards, Bryan Drewery -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJWYxi/AAoJEDXXcbtuRpfPghcIAMOzkIFfm4+s7MXi2/B6UrqB r9wvv9zsFZ5ytASFhuecm+47ZWkJq3sKmlw3vXHqRJRR8V9r7vhGBSINfwrOTiUE ZMIk29/tJ1Bkdl9SDt34xU38WZD1gz+35qNZQbrpr6g1+2qGr2iX/UEOBGp6Bzrl O6EAK18a34cbOGSwMCVxZoLhsHD2fjbLnGRROILKztE+h3s4Q2P+phQCzSGnL0vD DqY4dLi5mKJgOj68xNJQeQKZm10+Dt+F8zdSspA6coDdnU4uRe5YxLxNLeJXpHav CsxYLZCrYvvYaMhXHL69Lq70UdWR3L2k6bZkC/QjZlJeFNMZ6WjGSgCXrG9VWdQ= =CJVz -----END PGP SIGNATURE-----