Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Apr 2004 09:29:01 -0700 (PDT)
From:      Nate Lawson <nate@root.org>
To:        "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/contrib/dev/acpica acfreebsd.h
Message-ID:  <20040405092818.G21267@root.org>
In-Reply-To: <Pine.BSF.4.53.0404051454380.15681@e0-0.zab2.int.zabbadoz.net>
References:  <200404050403.i3543949049935@repoman.freebsd.org> <Pine.BSF.4.53.0404050953240.15681@e0-0.zab2.int.zabbadoz.net> <20040405110155.GB608@wombat.fafoe.narf.at> <Pine.BSF.4.53.0404051454380.15681@e0-0.zab2.int.zabbadoz.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 5 Apr 2004, Bjoern A. Zeeb wrote:
> On Mon, 5 Apr 2004, Stefan Farfeleder wrote:
> > On Mon, Apr 05, 2004 at 09:55:02AM +0000, Bjoern A. Zeeb wrote:
> >
> > > I am now getting this when doing a make buildworld:
> > >
> > > ===> sys/boot/i386/libi386
> > > cc -O -pipe  -DCOMPORT=0x3f8 -DCOMSPEED=9600 -DTERM_EMU
> > > 	-I/u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/../../common
> > > 	-I/u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/../btx/lib
> > > 	-I/u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/../../../contrib/dev/acpica
> > > 	-I/u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/../../.. -I.
> > > 	-I/u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/../../../../lib/libstand/
> > > 	-ffreestanding -mpreferred-stack-boundary=2  -c
> > > /u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/biosacpi.c
> > > In file included from /u2/src/HEAD/compile-20040405-01/sys/contrib/dev/acpica/acfreebsd.h:165,
> > >                  from /u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386/biosacpi.c:34:
> > > /usr/obj/u2/src/HEAD/compile-20040405-01/i386/usr/include/ctype.h:88: error: syntax error before "int"
> > > *** Error code 1
> > >
> > > Stop in /u2/src/HEAD/compile-20040405-01/sys/boot/i386/libi386.
> >
> > I apologise, my testing method was obviously flawed :(  Here's a quick
> > fix, it doesn't include <ctype.h> if we're compiling with -ffreestanding
> > and using <stand.h>.  The alternative would be to include <ctype.h>
> > before the ACPI headers in all userland applications.
>
> If this patch helps can somebody please commit it and unbreak world ?

No, I am backing out the original commit instead.  Checking for compile
flags is a hack.

-Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040405092818.G21267>