From owner-svn-ports-all@FreeBSD.ORG  Sun Dec 21 15:16:06 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7146DC53;
 Sun, 21 Dec 2014 15:16:06 +0000 (UTC)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B71E3FDB;
 Sun, 21 Dec 2014 15:16:06 +0000 (UTC)
Received: from [192.168.192.25] (75-161-68-224.albq.qwest.net [75.161.68.224])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id 772F81140AC;
 Sun, 21 Dec 2014 08:15:58 -0700 (MST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
Subject: Re: svn commit: r375010 - head/Mk
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201412201559.sBKFxl9d088764@svn.freebsd.org>
Date: Sun, 21 Dec 2014 08:15:56 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <46210F48-0FE2-4B61-AA64-17472B9EAEEB@adamw.org>
References: <201412201559.sBKFxl9d088764@svn.freebsd.org>
To: Steve Wills <swills@freebsd.org>
X-Mailer: Apple Mail (2.1993)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Dec 2014 15:16:06 -0000

> On 20 Dec, 2014, at 8:59, Steve Wills <swills@freebsd.org> wrote:
>=20
> Author: swills
> Date: Sat Dec 20 15:59:46 2014
> New Revision: 375010
> URL: https://svnweb.freebsd.org/changeset/ports/375010
> QAT: https://qat.redports.org/buildarchive/r375010/
>=20
> Log:
>  Make using GitHub releases easier
>=20
>  Differential Revision:	https://reviews.freebsd.org/D1340
>  With hat:	portmgr
>=20
> -#
> -# GitHub files can also be obtained, without the need for any of the =
above, by doing:
> -#
> -# MASTER_SITES=3D	=
http://github.com/accountname/${PORTNAME}/archive/${PORTVERSION}.tar.gz?du=
mmy=3D/
> -#

That shortcut code still works, and it's still simpler than using =
USE_GITHUB and having to keep track of commit hashes on every update. =
Why remove it?

The PH says, "If the distribution file comes from a specific commit or =
tag on GitHub for which there is no officially released file, [...]". =
That code block is a way to get it when there IS an officially released =
file.

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org