Date: Thu, 3 Oct 1996 03:30:02 -0700 (PDT) From: Peter Childs <pjchilds@imforei.apana.org.au> To: freebsd-bugs Subject: Re: bin/1494: some patches to ijppp Message-ID: <199610031030.DAA19442@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/1494; it has been noted by GNATS.
From: Peter Childs <pjchilds@imforei.apana.org.au>
To: jkh@time.cdrom.com (Jordan K. Hubbard)
Cc: FreeBSD-gnats-submit@freefall.freebsd.org
Subject: Re: bin/1494: some patches to ijppp
Date: Thu, 3 Oct 1996 19:38:54 +0930 (CST)
> What's your confidence level with this stuff? Have you had any other
> folks in the FreeBSD community BETA testing it?
Got a machine with 38 serial ports running it :) I've installed it
on two other public access sites over here, and my own machine.
I've had a few people grab it via ftp.. and haven't had any
problems... I just added the stuff from the (rejected) proposal
MS's has got on its web site somewhere.
> I can sense some very understandable frustration here, but you also
> have to try and see this from my perspective - I'd *love* to put a
> potentially nice, new feature like this into 2.1.6's PPP, but what if
> it then breaks the whole show? They're not going to scream at you,
> they're going to scream at *me* and anything you can point to which
> might increase my confidence level would make me more willing, in
> turn, to take the risk (even if only with 2.2).
Grin.. ijppp is written very well. There are some parts to the
patch you could leave out if you were unsure. The 2.1.5 ppp
from memory has a big bogus "limited to 10 interfaces" bug...
The patch addresses a few areas...
. The ms extentions - trival
This isn't going to break anything. It adds a few bits to
the negotiation phase. It can be selectively enabled or
disabled in the ppp.conf file.
. The pap password stuff - hmmm...
Well i personally probably wouldn't be stuffed compiling this
in by default, but i'd leave the code there so that others can
see that using a nasty big plain text /etc/ppp/pap.secrets
file is necessary.
. Changes to the GetIfIndex(name) function...
Someone else posted these somewhere.. they work here and it
make sense rather than dynamically allocated stuff.
2.1.5-stable is the stable tree.. but 2.2-current is the development
tree. Stick it in 2.2 and see how it goes... Since i wrote it I haven't
had one bug.. but that's mainly due to the great initial coding of
ijppp.
A quick scan of the "ms extension" patch shows that it doesn't use
malloc, recursion, or anything nasty that could explode...
Regards,
Peter
--
Peter Childs --- http://www.imforei.apana.org.au/~pjchilds
Finger pjchilds@al.imforei.apana.org.au for public PGP key
Drag me, drop me, treat me like an object!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199610031030.DAA19442>