From owner-svn-ports-head@FreeBSD.ORG Wed Mar 26 22:26:24 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2BB8E6BB; Wed, 26 Mar 2014 22:26:24 +0000 (UTC) Received: from mail-yh0-x22d.google.com (mail-yh0-x22d.google.com [IPv6:2607:f8b0:4002:c01::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B553E605; Wed, 26 Mar 2014 22:26:23 +0000 (UTC) Received: by mail-yh0-f45.google.com with SMTP id a41so2791948yho.32 for ; Wed, 26 Mar 2014 15:26:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=J6nml0WVoxBwVUhnNK9mQJENNANzEp2FTRj0HZ/Cml8=; b=TipaATgoDrPxKjbEsdSY8ubp9qF324qlV1rN8kkiUc5TwwaY9CoGVeMEDfqcTvVKSC Rz0/VPPRVDj1xGePIs4DmYOFYNhN+DhLiGeJqJOGbO60YIM9YPKl8ZIJamgaStHUfGYT 5EZGzome2xSIq5puat9NY54StN5aCtolQA7Ed0tcX9dZuf+mYgBeDkSoYo6IYO+DYtVJ P626THFPDLob0m6fq3nJfaC9HtVxfIOp0MiIWVtX0aCV1gMFvNqrv6HK7iHPGXmT3aJ6 88tubZH5kAas8PWkhPxCybP73T0hAVKxuTdu6/EFVDmepD0HM/PZbtbrav3goJNEz22C Cl2A== MIME-Version: 1.0 X-Received: by 10.236.149.2 with SMTP id w2mr6155356yhj.114.1395872782872; Wed, 26 Mar 2014 15:26:22 -0700 (PDT) Sender: antoine.brodin.freebsd@gmail.com Received: by 10.170.80.11 with HTTP; Wed, 26 Mar 2014 15:26:22 -0700 (PDT) In-Reply-To: <533351FC.2020908@marino.st> References: <201403262018.s2QKId7b067131@svn.freebsd.org> <533351FC.2020908@marino.st> Date: Wed, 26 Mar 2014 23:26:22 +0100 X-Google-Sender-Auth: Rz0xn0HW5eUliCwrF-Fjct2vfvY Message-ID: Subject: Re: svn commit: r349288 - head/archivers/ocaml-bz2 From: Antoine Brodin To: John Marino Content-Type: text/plain; charset=ISO-8859-1 Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Mar 2014 22:26:24 -0000 On Wed, Mar 26, 2014 at 11:17 PM, John Marino wrote: > On 3/26/2014 21:18, Antoine Brodin wrote: >> Author: antoine >> Date: Wed Mar 26 20:18:38 2014 >> New Revision: 349288 >> URL: http://svnweb.freebsd.org/changeset/ports/349288 >> QAT: https://qat.redports.org/buildarchive/r349288/ >> >> Log: >> Stage support >> >> Modified: >> head/archivers/ocaml-bz2/Makefile >> >> Modified: head/archivers/ocaml-bz2/Makefile >> ============================================================================== >> --- head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:09:29 2014 (r349287) >> +++ head/archivers/ocaml-bz2/Makefile Wed Mar 26 20:18:38 2014 (r349288) >> @@ -12,10 +12,9 @@ DISTNAME= caml${PORTNAME}-${PORTVERSION} >> MAINTAINER= jaapb@kerguelen.org >> COMMENT= OCaml library to manipulate bz2 files >> >> +DESTDIRNAME= DONTUSEIT >> GNU_CONFIGURE= yes >> USES= gmake >> -NO_STAGE= yes >> - > > You left USE_OCAML_LDCONFIG= yes. > Won't this create an ldconf file that will get added to plist and will > conflict potentially with the real ldconf? > > USE_OCAML_WASH is also set. Is this knob actually desireable? Why is > it needed if it's competing with pkg to remove files? > > I'm not saying I'm right, I'm just trying to learn this. Hi, I modifed bsd.ocaml.mk so now USE_OCAML_LDCONFIG doesn't violate stagedir anymore. For USE_OCAML_WASH, I have doubts on its usefulness, maybe it should be garbage collected in all the tree. Cheers, Antoine