From owner-freebsd-stable@freebsd.org Wed Oct 5 13:10:38 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD04DAF3FED for ; Wed, 5 Oct 2016 13:10:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 1F926FF5 for ; Wed, 5 Oct 2016 13:10:37 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id QAA04001; Wed, 05 Oct 2016 16:10:36 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1brly0-0008A1-0o; Wed, 05 Oct 2016 16:10:36 +0300 Subject: Re: aibs(4) / atk0110 support for newer systems To: Torfinn Ingolfsen , freebsd-stable@FreeBSD.org References: <86cf8380-ac6f-55f0-f0f8-16000d7f04b2@FreeBSD.org> <20160930145704.4dbc9d90011154b38493964e@getmail.no> <7d498084-ec05-d4c9-5f49-6aef32495caf@FreeBSD.org> <20160930205928.77d7e74f7bd1a35fcf1aa50a@getmail.no> <7a868c22-e0bd-f677-e4ad-2bdf6f3605d0@FreeBSD.org> <20161003201511.7258687453f12c44a46a361a@getmail.no> <20161005143723.4273657959160b67637a5adf@getmail.no> From: Andriy Gapon Message-ID: <4c431c8a-7c8c-4336-b948-6e9ae882c0fc@FreeBSD.org> Date: Wed, 5 Oct 2016 16:09:40 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161005143723.4273657959160b67637a5adf@getmail.no> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 13:10:38 -0000 On 05/10/2016 15:37, Torfinn Ingolfsen wrote: > On Mon, 3 Oct 2016 23:05:48 +0300 > Andriy Gapon wrote: > >> Yes, it does. Thank you! >> It seems like a couple of minor changes are not in the source tree that you are >> using. One is some casts in a diagnostic printf and the other is a different >> rounding of 0C in Kelvins. >> I've generated a patch that should apply to your tree: >> https://people.freebsd.org/~avg/aibs-ggrp-gitm.93.diff >> Please try. > > The patch applied cleanly (I removed the old one with patch -R first): Good! > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c: In function 'aibs_attach': > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: warning: 's_idx' may be used uninitialized in this function > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:252: note: 's_idx' was declared here > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: warning: 'so' may be used uninitialized in this function > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:256: note: 'so' was declared here > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: warning: 'name' may be used uninitialized in this function > /usr/src/sys/modules/acpi/aibs/../../../dev/acpi_support/atk0110.c:253: note: 'name' was declared here > *** [atk0110.o] Error code 1 > > Stop in /usr/src/sys/modules/acpi/aibs. > > Do I have to do something more in order to build the new module? > Seems like this is a clang vs gcc issue as I didn't get warnings here. Could you please simply add initialization to those variables in aibs_attach_ggrp()? E.g.: s_idx = NULL; so = NULL; Thank you! -- Andriy Gapon