Date: Wed, 31 Oct 2012 18:24:29 +0100 From: nemysis <nemysis@gmx.ch> To: FreeBSD-gnats-submit@FreeBSD.org Cc: bsam@FreeBSD.org Subject: ports/173243: [PATCH] textproc/goldendict: Changed License place, WWW, simplified MASTER_SITES Message-ID: <20121031172434.15D257E1@hub.freebsd.org> Resent-Message-ID: <201210311730.q9VHU12v046907@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 173243
>Category: ports
>Synopsis: [PATCH] textproc/goldendict: Changed License place, WWW, simplified MASTER_SITES
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Oct 31 17:30:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: nemysis
>Release: FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC
>Description:
Makefile changed:
+MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/1.0/
Changed place that portlint works
+LICENSE= GPLv3
Channged pkg-descr
+WWW: http://goldendict.org/
Port maintainer (bsam@FreeBSD.org) is cc'd.
Generated and tested manually, tested with port test and with RedPorts (all RELEASES, CLANG), sent with FreeBSD Port Tools 0.99_6 (mode: change, diff: ports)
>How-To-Repeat:
Original Port:
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
FATAL: Makefile: extra item "LIB_DEPENDS" placed in the LICENSE section.
WARN: Makefile: "LICENSE" has to appear earlier.
1 fatal error and 3 warnings found.
This patch:
portlint -A
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .0 in hunspell-1.3.0 unless it is really necessary.
0 fatal errors and 3 warnings found.
port test: clean
Build log
https://redports.org/buildarchive/20121031144532-58273/
>Fix:
--- goldendict-1.0.1_5.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/textproc/goldendict/Makefile ./Makefile
--- /usr/ports/textproc/goldendict/Makefile 2012-07-19 22:15:37.000000000 +0200
+++ ./Makefile 2012-10-31 15:31:03.000000000 +0100
@@ -9,17 +9,18 @@
PORTVERSION= 1.0.1
PORTREVISION= 5
CATEGORIES= textproc
-MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/${PORTVERSION:C|(.*)\.[0-9]*$|\1|}/
-DISTNAME= ${PORTNAME}-${PORTVERSION}-src
+MASTER_SITES= SF/${PORTNAME}/${PORTNAME}/1.0/
+DISTNAME= ${PORTNAME}-${DISTVERSION}-src
MAINTAINER= bsam@FreeBSD.org
COMMENT= A feature-rich dictionary lookup program (with QT lib)
+LICENSE= GPLv3
+
LIB_DEPENDS= hunspell-1.3.0:${PORTSDIR}/textproc/hunspell \
execinfo:${PORTSDIR}/devel/libexecinfo \
vorbis:${PORTSDIR}/audio/libvorbis
-LICENSE= GPLv3
USE_BZIP2= yes
HAS_CONFIGURE= yes
USE_GNOME= pkgconfig
diff -ruN --exclude=CVS /usr/ports/textproc/goldendict/pkg-descr ./pkg-descr
--- /usr/ports/textproc/goldendict/pkg-descr 2009-11-13 15:07:48.000000000 +0100
+++ ./pkg-descr 2012-10-31 15:19:04.000000000 +0100
@@ -11,4 +11,4 @@
LICENSE: GPL3 or later
-WWW: http://goldendict.berlios.de/
+WWW: http://goldendict.org/
--- goldendict-1.0.1_5.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031172434.15D257E1>