Date: Sat, 10 Nov 2018 10:30:02 +0000 (UTC) From: Hans Petter Selasky <hselasky@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: svn commit: r340315 - stable/12/sys/dev/usb/controller Message-ID: <201811101030.wAAAU2Ud031190@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: hselasky Date: Sat Nov 10 10:30:01 2018 New Revision: 340315 URL: https://svnweb.freebsd.org/changeset/base/340315 Log: MFC r340212: Sometimes the complete split packet may be queued too early and the transaction translator will return a NAK. Ignore this message and retry the complete split instead. Approved by: re (kib) Sponsored by: Mellanox Technologies Modified: stable/12/sys/dev/usb/controller/dwc_otg.c Directory Properties: stable/12/ (props changed) Modified: stable/12/sys/dev/usb/controller/dwc_otg.c ============================================================================== --- stable/12/sys/dev/usb/controller/dwc_otg.c Sat Nov 10 03:10:22 2018 (r340314) +++ stable/12/sys/dev/usb/controller/dwc_otg.c Sat Nov 10 10:30:01 2018 (r340315) @@ -1432,6 +1432,19 @@ dwc_otg_host_data_rx(struct dwc_otg_softc *sc, struct goto receive_pkt; } } else if (td->ep_type == UE_ISOCHRONOUS) { + if (td->hcsplt != 0) { + /* + * Sometimes the complete + * split packet may be queued + * too early and the + * transaction translator will + * return a NAK. Ignore + * this message and retry the + * complete split instead. + */ + DPRINTF("Retrying complete split\n"); + goto receive_pkt; + } goto complete; } td->did_nak = 1;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201811101030.wAAAU2Ud031190>