From owner-cvs-src@FreeBSD.ORG Tue Mar 7 00:39:13 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id C515416A420; Tue, 7 Mar 2006 00:39:12 +0000 (GMT) (envelope-from green@green.homeunix.org) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.13.4/8.13.1) with ESMTP id k270dCdg020120; Mon, 6 Mar 2006 19:39:12 -0500 (EST) (envelope-from green@green.homeunix.org) Received: (from green@localhost) by green.homeunix.org (8.13.4/8.13.1/Submit) id k270dBNQ020119; Mon, 6 Mar 2006 19:39:11 -0500 (EST) (envelope-from green) Date: Mon, 6 Mar 2006 19:39:11 -0500 From: Brian Fundakowski Feldman To: Pawel Jakub Dawidek Message-ID: <20060307003911.GB7835@green.homeunix.org> References: <200602221021.k1MAL5qF031937@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200602221021.k1MAL5qF031937@repoman.freebsd.org> User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom/raid3 g_raid3.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Mar 2006 00:39:13 -0000 On Wed, Feb 22, 2006 at 10:21:05AM +0000, Pawel Jakub Dawidek wrote: > pjd 2006-02-22 10:21:05 UTC > > FreeBSD src repository > > Modified files: > sys/geom/raid3 g_raid3.c > Log: > Do not use bio structure after g_io_deliver(), it may not longer by valid. > > Found and fixed by: Vsevolod Lobko > MFC after: 3 days I actually found and fixed it half a year ago... could you please integrate the rest of the fixes from my changes back then? A short-term low-memory deadlock is still possible (observed in practice). I think the changes also improve readability -- see for example the reason r1.46 existed. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\