From owner-svn-src-all@freebsd.org Wed Oct 16 20:45:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7CA8014F75D; Wed, 16 Oct 2019 20:45:22 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46tknt2bZbz4FLF; Wed, 16 Oct 2019 20:45:21 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id C1BC1260082; Wed, 16 Oct 2019 22:45:13 +0200 (CEST) Subject: Re: svn commit: r353633 - head/sys/ofed/include/rdma To: Gleb Smirnoff Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201910160856.x9G8u7Sg065578@repo.freebsd.org> <20191016165533.GT4086@FreeBSD.org> From: Hans Petter Selasky Message-ID: Date: Wed, 16 Oct 2019 22:44:23 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191016165533.GT4086@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46tknt2bZbz4FLF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.988,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Oct 2019 20:45:22 -0000 On 2019-10-16 18:55, Gleb Smirnoff wrote: > On Wed, Oct 16, 2019 at 08:56:07AM +0000, Hans Petter Selasky wrote: > H> Author: hselasky > H> Date: Wed Oct 16 08:56:07 2019 > H> New Revision: 353633 > H> URL: https://svnweb.freebsd.org/changeset/base/353633 > H> > H> Log: > H> VLAN_TRUNKDEV() requires epochification in ibcore after r353292. > > Note that neither VLAN_DEVAT() not VLAN_TRUNKDEV() reference the > returned structure, so after epoch is exited the link is no longer > safe. > > Does ibcore require these two functions in non-fast code paths? > Yes, ibcore use these in non-fast path. Typically the ifnet's used will be referenced, and only the pointer value is needed for deciding if a packet is designated for the given network device or not. --HPS