From owner-svn-src-all@FreeBSD.ORG Sat Sep 8 19:24:04 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CBDE1065672; Sat, 8 Sep 2012 19:24:04 +0000 (UTC) (envelope-from jilles@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 08FC48FC0A; Sat, 8 Sep 2012 19:24:04 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q88JO3Y1042161; Sat, 8 Sep 2012 19:24:03 GMT (envelope-from jilles@svn.freebsd.org) Received: (from jilles@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q88JO3Vg042159; Sat, 8 Sep 2012 19:24:03 GMT (envelope-from jilles@svn.freebsd.org) Message-Id: <201209081924.q88JO3Vg042159@svn.freebsd.org> From: Jilles Tjoelker Date: Sat, 8 Sep 2012 19:24:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r240247 - head/bin/sh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Sep 2012 19:24:04 -0000 Author: jilles Date: Sat Sep 8 19:24:03 2012 New Revision: 240247 URL: http://svn.freebsd.org/changeset/base/240247 Log: sh: Remove XXX comment about removing nextopt(). Using nextopt() avoids depending on the BSD-specific optreset feature in getopt() and reduces code size (both source and binary). Modified: head/bin/sh/options.c Modified: head/bin/sh/options.c ============================================================================== --- head/bin/sh/options.c Sat Sep 8 18:35:15 2012 (r240246) +++ head/bin/sh/options.c Sat Sep 8 19:24:03 2012 (r240247) @@ -531,10 +531,6 @@ out: } /* - * XXX - should get rid of. have all builtins use getopt(3). the - * library getopt must have the BSD extension static variable "optreset" - * otherwise it can't be used within the shell safely. - * * Standard option processing (a la getopt) for builtin routines. The * only argument that is passed to nextopt is the option string; the * other arguments are unnecessary. It return the character, or '\0' on