Date: Fri, 22 Jun 2001 03:34:41 -0700 From: "David O'Brien" <obrien@FreeBSD.ORG> To: Dag-Erling Smorgrav <des@ofug.org> Cc: Mike Barcroft <mike@q9media.com>, Alexey Zelkin <phantom@freebsd.org.ua>, Peter Pentchev <roam@orbitel.bg>, hackers@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: whois(1) patch for review Message-ID: <20010622033441.A197@dragon.nuxi.com> In-Reply-To: <xzpsngtcn1u.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Jun 22, 2001 at 03:37:17AM %2B0200 References: <B757DEA3.D5A%mike@q9media.com> <xzpsngtcn1u.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 22, 2001 at 03:37:17AM +0200, Dag-Erling Smorgrav wrote: > Mike Barcroft <mike@q9media.com> writes: > > Arg.. I wish you had contacted me before doing this work. From looking at > > your patch, your using an old copy of my work. The newest one is available > > at: http://testbed.q9media.net/freebsd/whois.patch and will be committed > > very-shortly-now(tm). > > Since Mike's patch is a style cleanup with no functional impact except > plugging a memory leak, I feel it's better to commit it first, and > merge in Alexey's patch later, after it's been reviewed by this forum. Uh wrong. There were other non-style bits than just the memory leak. For instance the cast changes are functionalty related, not style. It should have been done in two commits. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010622033441.A197>