From owner-svn-src-head@freebsd.org Sat Aug 20 18:09:03 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 972AEBC0FDE; Sat, 20 Aug 2016 18:09:03 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B5CB1515; Sat, 20 Aug 2016 18:09:03 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-it0-x229.google.com with SMTP id f6so50941699ith.0; Sat, 20 Aug 2016 11:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4z1cCjGuWk0OgmimvNkvzCSHCDErys4eX9qRzUhqty0=; b=ZG4ZMZMLZZSo9h/XZB6+9Kg0mN/WoZIMXLXebQdX9nnIAixRgiYDQGFr8CZV236g+c iaJd0TQGXU/EUvxSbIgIGzuyPJVTgoKgazPcXGpWTArlz2p2S/RQz/iDdX1pWQCKzdxg woOSJpMuSj4dxFt+XCfN5vErt3dc2zmn2xx+Z7AB1fn7U1Oc24a6gmNHlAFPAxMSgUS5 Z+iQoCyKK/517Wu2DK7eD51/OnbwaV0NTDqmi/5jM0CTQaS3laQlozJbUQbsmj2qDqGa wmZPf2jNbCohC6coNS7ML3AF6BAyL8avHVV4lMwmoF4C2r1zlIusVieZZzoO80PQ3xwg 53eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4z1cCjGuWk0OgmimvNkvzCSHCDErys4eX9qRzUhqty0=; b=JPFg52sI2s++fSx0SdF6Kc2Ll2M9eUgvHdtHah/nZAubpcVzJ5F4K6+cCObbz6yY4v 8UqlQYovfBAPzKxmpDGFsYwS3fY7MyhbdnyhTSyG9l6oQSmII59rwEycD7gDkG4TA0ft rnCymDa0zoQIeWdtUmf96yupbo+rRRsp3xpMVG0l9hPb+ZUtVLo1yAcjluqj2g7LacKO Mc+IOZF6/9NQR7l1QaP3Fs5bQEMGbWtlDKwWPFjmMz2GADyKDXL0xBS/9wOvnmRFIUsb 0KJZOYfkeTx8B2AnlrTm9Ue8kfgWr47O3ZEyiUJFsp68RNJBFdSyIYlSyGbGAVHVt3sm Zn6A== X-Gm-Message-State: AEkoousWlkIwyrp3UCWnuBjtyTh/GpTG52JtoPGy1U+cSUMQx8JsZE9zqwZuhPIxtTxKQdfAMEBQiLWrQIe7xA== X-Received: by 10.36.124.141 with SMTP id a135mr12217351itd.25.1471716542851; Sat, 20 Aug 2016 11:09:02 -0700 (PDT) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.36.141.129 with HTTP; Sat, 20 Aug 2016 11:09:00 -0700 (PDT) In-Reply-To: References: <201608182259.u7IMx5oW002018@repo.freebsd.org> <4fbc2e1d-3a62-5963-83d5-f9c931503e51@fastmail.net> <3806700d-ed27-7915-4818-c2d64f7b806d@fastmail.net> <6f4449f2-d145-8b49-c3f0-433e8ff4d2a2@fastmail.net> <20160820173050.GQ22212@zxy.spb.ru> From: Adrian Chadd Date: Sat, 20 Aug 2016 11:09:00 -0700 X-Google-Sender-Auth: YziLzUTXKROMF11KP8fB-oTNByE Message-ID: Subject: Re: svn commit: r304436 - in head: . sys/netinet To: Ryan Stone Cc: Slawa Olhovchenkov , Bruce Simpson , "svn-src-head@freebsd.org" , Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2016 18:09:03 -0000 On 20 August 2016 at 11:02, Ryan Stone wrote: > On Sat, Aug 20, 2016 at 1:30 PM, Slawa Olhovchenkov wrote: >> >> For host enought have [hidden] alias with broadcsts bits. >> Anyway, don't should relay on the L2 information, you can recive L3 >> unicast addressed packets (with alien dst IP address) in L2 broadcas >> packet. > > > This is still handled correctly. The new code only checks for L3 broadcast > addresses on L2 broadcast packets, but we still check the L3 address before > treating it as a broadcast. The problem is that I assumed that all paths > into the IP stack would set M_BCAST, but as Bruce has pointed out there are > cases like PPP which do not. Hi, So why not fix those paths? -adrian