From owner-freebsd-arch Wed Aug 21 17:45: 8 2002 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC15837B400; Wed, 21 Aug 2002 17:45:03 -0700 (PDT) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2D79143E70; Wed, 21 Aug 2002 17:45:03 -0700 (PDT) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id RAA96162; Wed, 21 Aug 2002 17:33:30 -0700 (PDT) Received: (from archie@localhost) by arch20m.dellroad.org (8.11.6/8.11.6) id g7M0Wil08432; Wed, 21 Aug 2002 17:32:44 -0700 (PDT) (envelope-from archie) From: Archie Cobbs Message-Id: <200208220032.g7M0Wil08432@arch20m.dellroad.org> Subject: Re: NULL In-Reply-To: <20020822001115.GA45577@dragon.nuxi.com> "from David O'Brien at Aug 21, 2002 05:11:16 pm" To: obrien@FreeBSD.ORG Date: Wed, 21 Aug 2002 17:32:44 -0700 (PDT) Cc: Archie Cobbs , "M. Warner Losh" , freebsd-arch@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG David O'Brien writes: > > The patch makes 'make buildworld' and 'make buildkernel KERNCONF=LINT' > > work for me; fyi I have "NO_WERROR= YES" in /etc/make.conf. > > > > Does anyone have an objection to this patch? > > Yes -- only because you haven't tested with the defaults of not having > NO_WERROR=YES. I.e., if you commit this patch you really don't know if > you will be breaking the world for the rest of us. OK. I wasn't sure what the current state of NO_WERROR was these days after reading this in UPDATING... 20020815: A "bug" in gcc(1) that was hiding warning in system headers was fixed. It's probably time to add -DNO_WERROR to your make line again. In any case, if/when this gets checked in I'll first make sure the kernel builds with -Werror. Thanks, -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message