From owner-svn-src-all@freebsd.org Fri Mar 15 15:10:52 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05413154B637 for ; Fri, 15 Mar 2019 15:10:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A37F6C13B for ; Fri, 15 Mar 2019 15:10:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id v20so10421064qtv.12 for ; Fri, 15 Mar 2019 08:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t7Zh0KGEksOvJFlUEZX10svqGHjAmqWX9zzZT4B2ScM=; b=ySB54chPYQTGlZkjFYk+g7F+IbQZRuoEXMgpLoRWW6TVgF8hsHPBatrIfPwWQTJnmE cGmv7dt6+ouCxKdyMx44keaI5fgQ6mlbTxBOa9NwRKmpkxhR6N5QjZQ4PsCod+SvTTk1 oGeewg8cO5MbPxbG6pqQ7mWaJpExMwk+3ddhxOiQqvSbL72lGKpkp9uGNhwccqz4xrOL cKBwBXSKsEq1X/JjXYu4iFmDNDuQKogXeyAbLkUeDYXO1oRF6ZTECsOFRigm3wZyW1fB PpCS0IccNgdR8Nf/ZlPcnNXFG7XwMN8jQBTOs7iZxPYPWh4mhCDg5/KNxYmAx0Sp1HnI nSqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t7Zh0KGEksOvJFlUEZX10svqGHjAmqWX9zzZT4B2ScM=; b=bu1dFPx6/w9NRoQdqHd7uhHniqRueYcC8UhpWlkn/7jvEfm+bDfQxqXRlxDPrjApxm SiAmjixMz97QBeIqkNV/1p+Wcwnq675rV2d5qg25J4OMCI6QFE6FhduEZxc+OA1ctxqE PehRHyEfuV92RQ4gITlaMEIYzHrEYpfDRb+b8j70eS1AAJnprQl65jdsYqGvFX+ByNkp PQNZ8BDJGnfz9HfUaHxiYjAWdRC19RVTj3amBptCNCDBTMagkYrpugwukGDU21B8TdEc FcdKGHnkbTsF8w+Xi8589UAAblX7VczP5uHms66JEuW//9dQfOEHntdZI48Do9zBNSay jeoQ== X-Gm-Message-State: APjAAAVvpLRR3BbBzIUMEDKhKwM7r1zANogqm4EG9YIngyULqbWBdN3p r7xxXRWZl3mhlyCAZUAvfF1sBqRUgODVsPI91pykeg== X-Google-Smtp-Source: APXvYqx1YtcsZD8bnpRhBn/QUospvp7V5Vg6C4BdOeoO66UjJsoDMZspj4A5CQ8E4UOeIKdrmhVyMzV6P99qpPCkLD4= X-Received: by 2002:ac8:5286:: with SMTP id s6mr3302941qtn.118.1552662650788; Fri, 15 Mar 2019 08:10:50 -0700 (PDT) MIME-Version: 1.0 References: <201903150211.x2F2BSai079898@repo.freebsd.org> <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> In-Reply-To: <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> From: Warner Losh Date: Fri, 15 Mar 2019 09:10:39 -0600 Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: "Rodney W. Grimes" Cc: Chuck Tuffli , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 9A37F6C13B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.984,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 15:10:52 -0000 On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes wrote: > > Author: chuck > > Date: Fri Mar 15 02:11:28 2019 > > New Revision: 345171 > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > Log: > > Fix bhyve PCIe capability emulation > > > > PCIe devices starting with version 1.1 must set the Role-Based Error > > Reporting bit. > > > > And while we're in the neighborhood, generalize the code assigning the > > device type. > > > > Reviewed by: imp, araujo, rgrimes > > Approved by: imp (mentor) > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D19580 > > This code requires maintainer approval before a commit, > though this was well reviewed that doesnt exclude it > from the MAINTAINERS entry. > > Leave it for now, I am sure jhb or thyco are fine with it, > this is just a heads up FYI for future commits. > > Bhyve code has been and still is under a fairly tight > MAINTAINER status. > There is no such thing as a hard lock in FreeBSD. This sounds like you are advocating for that, but that's not the case. Stop this stupid nitpicking for single line commits. We don't have that culture any more and it's really pissing a lot of people off. The MAINTAINERS file even says this: Please note that the content of this file is strictly advisory. And the entry for bhyve doesn't say things are mandatory, just requested. Jumping on people's case like this, for a review you yourself were on and approved but made no mention of seeking further review / approval, is demotivating and toxic. Please stop. Warner > head/usr.sbin/bhyve/pci_emul.c > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > ============================================================================== > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 > (r345170) > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 > (r345171) > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, int > type) > > bzero(&pciecap, sizeof(pciecap)); > > > > pciecap.capid = PCIY_EXPRESS; > > - pciecap.pcie_capabilities = PCIECAP_VERSION | PCIEM_TYPE_ROOT_PORT; > > + pciecap.pcie_capabilities = PCIECAP_VERSION | type; > > + /* Devices starting with version 1.1 must set the RBER bit */ > > + if (PCIECAP_VERSION >= 1) > > + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > pciecap.link_capabilities = 0x411; /* gen1, x1 */ > > pciecap.link_status = 0x11; /* gen1, x1 */ > > > > > > > > -- > Rod Grimes > rgrimes@freebsd.org > >