From owner-cvs-all@FreeBSD.ORG Fri Apr 4 00:01:26 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 087B237B401; Fri, 4 Apr 2003 00:01:26 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id DA43D43FAF; Fri, 4 Apr 2003 00:01:21 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h3481Ggg099706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 4 Apr 2003 11:01:17 +0300 (EEST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h34818d7099682; Fri, 4 Apr 2003 11:01:08 +0300 (EEST) (envelope-from ru) Date: Fri, 4 Apr 2003 11:01:08 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20030404080108.GB95125@sunbay.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> <20030403093800.GA68012@dhcp01.pn.xcllnt.net> <20030403200459.H30311@gamplex.bde.org> <20030403151922.GA76895@sunbay.com> <20030403160301.GE17860@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="U+BazGySraz5kW0T" Content-Disposition: inline In-Reply-To: <20030403160301.GE17860@dragon.nuxi.com> User-Agent: Mutt/1.5.4i cc: src-committers@FreeBSD.org cc: Bruce Evans cc: Juli Mallett cc: cvs-src@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Marcel Moolenaar Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Apr 2003 08:01:26 -0000 --U+BazGySraz5kW0T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 03, 2003 at 08:03:01AM -0800, David O'Brien wrote: > On Thu, Apr 03, 2003 at 06:19:22PM +0300, Ruslan Ermilov wrote: > > I can fix this: > >=20 > > %%% > > Index: bsd.sys.mk >=20 > Would this be better? >=20 Hardly so. > Index: bsd.sys.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v > retrieving revision 1.11 > diff -u -r1.11 bsd.sys.mk > --- bsd.sys.mk 13 Nov 2002 13:49:29 -0000 1.11 > +++ bsd.sys.mk 3 Apr 2003 16:02:28 -0000 > @@ -24,17 +24,11 @@ > . if ${WARNS} > 3 > CFLAGS +=3D -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow= -Wcast-align > . endif > -. if ${WARNS} > 4 > -CFLAGS +=3D -Wuninitialized > -. endif > +# XXX: the warning that was here became problematic. > +#. if ${WARNS} > 4 This hardly can be classified like a fix. :-) > # BDECFLAGS > . if ${WARNS} > 5 > CFLAGS +=3D -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winl= ine -Wnested-externs -Wredundant-decls > -. endif > -. if ${WARNS} > 1 && ${WARNS} < 5 > -# XXX Delete -Wuninitialized by default for now -- the compiler doesn't > -# XXX always get it right. > -CFLAGS +=3D -Wno-uninitialized > . endif > . endif > =20 This would be backwards. -Wuninitialized is impled by -Wall, and revision 1.5 was about to fix this. Chees, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --U+BazGySraz5kW0T Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+jTvEUkv4P6juNwoRApmKAJ9shQ3na1UTR/qzRI2xoimm+g3s1ACdFnlX +FR0dcrBkByjC3+m6y8PT8s= =Tql8 -----END PGP SIGNATURE----- --U+BazGySraz5kW0T--