Date: Tue, 10 Mar 2009 14:43:09 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Luigi Rizzo <rizzo@iet.unipi.it> Cc: Lawrence Stewart <lstewart@freebsd.org>, src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r189612 - in user/lstewart/alq_varlen_8.x: sys/kern tools/test/alq Message-ID: <49B6DEED.4040902@FreeBSD.org> In-Reply-To: <20090310212511.GA53115@onelab2.iet.unipi.it> References: <200903100751.n2A7p02m050724@svn.freebsd.org> <49B6CF13.9060501@FreeBSD.org> <20090310212511.GA53115@onelab2.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote: > On Tue, Mar 10, 2009 at 01:35:31PM -0700, Doug Barton wrote: >> Lawrence Stewart wrote: >>> Author: lstewart >>> Date: Tue Mar 10 07:50:59 2009 >>> New Revision: 189612 >>> URL: http://svn.freebsd.org/changeset/base/189612 >>> >>> Log: >>> More bug and style fixes. >> Generally it's preferred not to mix these two types of changes. The >> preferred course of action is to make the style changes, confirm that >> the binary is unchanged (e.g., with sha256), then do substantive >> changes. Makes the revision history a little easier to parse down the >> road. > > well, this is a private branch after all :) 1. Good habits come from good practice, and what better place to practice than in a "private" branch? 2. Given that the stuff is in the FreeBSD repository, the presumption is that it is of some use to the wider FreeBSD community. So IMO community best practices are a reasonable expectation. Otherwise, why not just keep it local? Doug -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49B6DEED.4040902>