Date: Thu, 2 Jun 2005 11:48:49 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Xin LI <delphij@frontfree.net> Cc: delphij@delphij.net, freebsd-arch@freebsd.org Subject: Re: [PATCH RFC] Add a macro for null mount options to sbin/mount* Message-ID: <20050602114323.R98072@delplex.bde.org> In-Reply-To: <20050601134351.GA76097@frontfree.net> References: <1117613456.771.16.camel@spirit> <20050601211628.V96009@delplex.bde.org> <20050601134351.GA76097@frontfree.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 1 Jun 2005, Xin LI wrote:
> On Wed, Jun 01, 2005 at 09:23:23PM +1000, Bruce Evans wrote:
>>
>> MOPT_NULL is a poor name. It is not a null option, but a terminator that
>> happens to have nulls in it.
>
> Agreed... Will the patch found in attachment look better? It also
> updates the manpage.
The name is OK now, but see other replies about the changes obfuscating
the terminating condition.
% Index: mount/mntopts.h
% ===================================================================
% RCS file: /home/ncvs/src/sbin/mount/mntopts.h,v
% retrieving revision 1.25
% diff -u -r1.25 mntopts.h
% --- mount/mntopts.h 1 Jun 2005 09:39:34 -0000 1.25
% +++ mount/mntopts.h 1 Jun 2005 13:35:57 -0000
% @@ -66,7 +66,7 @@
% #define MOPT_AUTO { "auto", 0, 0, 0 }
%
% /* A handy macro as terminator of MNT_ array */
The previous patch also has some style bugs. I noticed mainly the missing
sentence (fragment) termination here. All other sentence (fragment)s in
comments in this file except ones to the right of code are terminated
normally.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050602114323.R98072>