From owner-svn-ports-head@freebsd.org  Thu Jun 25 12:21:54 2015
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 954A698C12B;
 Thu, 25 Jun 2015 12:21:54 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from vps.amdmi3.ru (vps.amdmi3.ru [109.234.38.216])
 by mx1.freebsd.org (Postfix) with ESMTP id 5D61D10E2;
 Thu, 25 Jun 2015 12:21:54 +0000 (UTC)
 (envelope-from amdmi3@amdmi3.ru)
Received: from hive.panopticon (unknown [78.153.152.119])
 by vps.amdmi3.ru (Postfix) with ESMTPS id E665BB0656;
 Thu, 25 Jun 2015 15:21:52 +0300 (MSK)
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
 by hive.panopticon (Postfix) with ESMTP id 44E8A10F;
 Thu, 25 Jun 2015 15:20:16 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
 id 1D9EB449DB; Thu, 25 Jun 2015 15:18:48 +0300 (MSK)
Date: Thu, 25 Jun 2015 15:18:48 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: marino@freebsd.org
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r390559 - head/ftp/vsftpd-ext
Message-ID: <20150625121847.GE93665@hades.panopticon>
References: <201506251134.t5PBYEir022391@svn.freebsd.org>
 <558BE843.6040001@marino.st>
 <20150625120314.GD93665@hades.panopticon>
 <558BEF7E.3080602@marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <558BEF7E.3080602@marino.st>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 12:21:54 -0000

* John Marino (freebsd.contact@marino.st) wrote:

> >>> Author: amdmi3
> >>> Date: Thu Jun 25 11:34:13 2015
> >>> New Revision: 390559
> >>> URL: https://svnweb.freebsd.org/changeset/ports/390559
> >>>
> >>> Log:
> >>>   - Mark BROKEN on 9.x i386:
> >>>   
> >>>   sysutil.c:(.text+0x13da): undefined reference to `__stack_chk_fail_local'
> >>>   
> >>>   Approved by:	portmgr blanket
> >>>   Reported by:	pkg-fallout
> >>>
> >>> Modified:
> >>>   head/ftp/vsftpd-ext/Makefile
> >>>
> >>> Modified: head/ftp/vsftpd-ext/Makefile
> >>> ==============================================================================
> >>> --- head/ftp/vsftpd-ext/Makefile	Thu Jun 25 11:19:54 2015	(r390558)
> >>> +++ head/ftp/vsftpd-ext/Makefile	Thu Jun 25 11:34:13 2015	(r390559)
> >>> @@ -42,6 +42,9 @@ CONFLICTS=	vsftpd-3* vsftpd${SSL_SUFFIX}
> >>>  .if ${OPSYS} == FreeBSD && ${OSVERSION} < 902001
> >>>  BUILD_DEPENDS+=	clang33:${PORTSDIR}/lang/clang33
> >>>  CC=		clang33
> >>> +.if ${ARCH} == i386
> >>> +BROKEN=		does not build on 9.x i386
> >>> +.endif
> >>>  .endif
> >>
> >> Should that be "BROKEN_FreeBSD_9" ?
> > 
> > No, as the patch says, it only affects i386.
> 
> sorry, I was not clear enough.
> I meant:
> 
> .if ${ARCH} == i386
> BROKEN_FreeBSD-9=		does not build on 9.x i386
> .endif
> 
> But it's academic.  The BROKEN is encapsulated by ".if ${OPSYS} ==
> FreeBSD && ${OSVERSION} < 902001" so it makes no difference.

I've though of it and decided that it's better not to mix and
duplicate old and new logic.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru      http://amdmi3.ru