From owner-svn-src-all@freebsd.org Thu Nov 2 17:38:52 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 493E9E5F4FD; Thu, 2 Nov 2017 17:38:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x22e.google.com (mail-pf0-x22e.google.com [IPv6:2607:f8b0:400e:c00::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 158362841; Thu, 2 Nov 2017 17:38:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x22e.google.com with SMTP id a8so216307pfc.0; Thu, 02 Nov 2017 10:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mNq2LkQvrv1iZsI3mYv2aTlkP5Jskw8+KORJu+188+4=; b=QASgfVGkEL6OyHTBQ67Z6r+H3NXec1+1nmdDnl+NMrbnS8IAhWou2xntkYoS4APPgX zV+izH0SlBnwtQ6qpSLrmi+/CbRpVQz4iyRcnuIs7DJR7KBUig3OEvCux/CjILG4OOmk EYnCbsG33cr0CUYiewYal1NNX1zPjsddMI9hpycOoOkDl8dT3WVCYRbuy9mNIoXNXU7Y KZ5BGA8z69qjvrZhuVDXZh6OQCz8DCmR27c7OEjNfxkABE/Gs8h370HTWN/5kLnTY04A /e3CykZwhE8qz+YzwUNzMJH/EtdVgYcmircvUFK4uUZvYhCH3hlZ8j0a/zRl2xgD4xga aYeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mNq2LkQvrv1iZsI3mYv2aTlkP5Jskw8+KORJu+188+4=; b=FfDnna5DRXBosZi46TSUyL/XMDRvipVU0+2IJ77eueTYE+zZ3oOfY9ltiW+5XJnY2o ljOuRLhp54C2KbWjb3h2s9h/nANjpBzR3zS35mkEFR78xmu0rGq9kn8hAoUSE4czqLf+ k/jlU2RC1GvKdAgiUKJF6oguB+qr/N6aJSppKqgP5TENw2a2lLtp3sRYOTidUdIYwGCf JoVDYDMs24Qop13VKMkfyai7OelMPIc2sOhzLUzIkYyl1MtcbSqfjc34lyFqoFCGs9ci 7zybfUN6rMz+beQ0/3WZwF4tRNopYmJyzNJ+i9CFldEJPbn6STvLNT9BfHTydctBsXAU tWHg== X-Gm-Message-State: AMCzsaWAFpT3YnAGaw/ILLaXi9zIG1xcnlqrMEY4RQueLLu+C6NCpvH7 aFiQH6I2oPW10IZOX5SuWGSP/DnmFlY= X-Google-Smtp-Source: ABhQp+TkMAhv+xLwuN8mtf0gihPVPtohr/FXJAjaIbqM+QCIXvjC6TfkRTrTnxya4GGZLJs6x2yjoQ== X-Received: by 10.98.31.14 with SMTP id f14mr4646026pff.235.1509644331109; Thu, 02 Nov 2017 10:38:51 -0700 (PDT) Received: from ?IPv6:2607:fb90:782a:a4d8:a5e7:98ca:fa4f:253b? ([2607:fb90:782a:a4d8:a5e7:98ca:fa4f:253b]) by smtp.gmail.com with ESMTPSA id c73sm9075525pfd.139.2017.11.02.10.38.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Nov 2017 10:38:50 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs From: Ngie Cooper X-Mailer: iPhone Mail (15B93) In-Reply-To: <201711021349.vA2Dn8Yg063559@repo.freebsd.org> Date: Thu, 2 Nov 2017 10:38:49 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <5199F871-5DE2-4434-87F2-FEF88DB34037@gmail.com> References: <201711021349.vA2Dn8Yg063559@repo.freebsd.org> To: Andriy Gapon Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 17:38:52 -0000 > On Nov 2, 2017, at 06:49, Andriy Gapon wrote: >=20 > Author: avg > Date: Thu Nov 2 13:49:08 2017 > New Revision: 325320 > URL: https://svnweb.freebsd.org/changeset/base/325320 >=20 > Log: > Disable posix_fallocate(2) for ZFS >=20 > The generic (naive) implementation of posix_fallocate cannot provide the > standard mandated guarantee that overwrites would never fail due to the l= ack > of free space. The fundamental reason is the copy-on-write architecture > of ZFS. Other features like compression and deduplication can also > increase the size difference between the (pre-)allocated dummy content > and the future content. >=20 > So, until ZFS can properly implement the feature it's better to report > that it is unsupported rather than providing an ersatz implementation. > Please note that EINVAL is used to report that the underlying file system= > does not support the operation (POSIX.1-2008). >=20 > illumos and ZoL seem to do the same. >=20 > MFC after: 3 weeks > Sponsored by: Panzura It=E2=80=99d be nice if it worked though and was reported via the file syste= m. Posix suggests it should be, as of 2013: http://austingroupbugs.net/view= .php?id=3D687 . Need to go poking around and see what=E2=80=99s in freebsd later on tonight.= Bug filed: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223383 . > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c >=20 > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c Thu= Nov 2 12:16:50 2017 (r325319) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c Thu= Nov 2 13:49:08 2017 (r325320) > @@ -6009,6 +6009,7 @@ struct vop_vector zfs_vnodeops =3D { > .vop_inactive =3D zfs_freebsd_inactive, > .vop_reclaim =3D zfs_freebsd_reclaim, > .vop_access =3D zfs_freebsd_access, > + .vop_allocate =3D VOP_EINVAL, > .vop_lookup =3D zfs_cache_lookup, > .vop_cachedlookup =3D zfs_freebsd_lookup, > .vop_getattr =3D zfs_freebsd_getattr, >=20