From owner-cvs-src@FreeBSD.ORG Mon Aug 2 07:33:52 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D675716A4CF; Mon, 2 Aug 2004 07:33:52 +0000 (GMT) Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DF1543D58; Mon, 2 Aug 2004 07:33:51 +0000 (GMT) (envelope-from danfe@regency.nsu.ru) Received: from regency.nsu.ru ([193.124.210.26]) by mx.nsu.ru with esmtp (Exim 4.32) id 1BrXTC-0004Hu-R2; Mon, 02 Aug 2004 14:42:54 +0700 Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i727ad9k066908; Mon, 2 Aug 2004 14:36:39 +0700 (NOVST) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.12.10/8.12.10/Submit) id i727adVm066890; Mon, 2 Aug 2004 14:36:39 +0700 (NOVST) (envelope-from danfe) Date: Mon, 2 Aug 2004 14:36:39 +0700 From: Alexey Dokuchaev To: Garance A Drosehn Message-ID: <20040802073639.GA62887@regency.nsu.ru> References: <200408012045.i71KjtFX087582@repoman.freebsd.org> <20040802034509.GB81089@regency.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/patch - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2004 07:33:53 -0000 On Mon, Aug 02, 2004 at 12:54:36AM -0400, Garance A Drosehn wrote: > At 10:45 AM +0700 8/2/04, Alexey Dokuchaev wrote: > >On Sun, Aug 01, 2004 at 08:45:55PM +0000, Garance A Drosehn wrote: > > > > >> Log Message: > > > Import of a BSD-licensed version of `patch', .... > > > Among other things, this version includes a --posix option > > > for strict POSIX conformance. > > > > > > This version is the current source from OpenBSD as of ... > > > >May I ask why you preferred OpenBSD's version over NetBSD's? > > The last thing I imported was pkill, and I imported that from > NetBSD. Seemed fair to take this from OpenBSD. OpenBSD also > had done the --posix work, which seemed like a good starting > point. > > Also, OpenBSD had already gone through and made many style(9) > changes, such as changing the indent from 2 blanks to 1 tab. > It seemed sub-optimal to import something, and then bloat the > CVS repository by having to change almost every line due to > style issues. Fair enough. > > The end result is going to be about the same, since my intent > is to make whatever changes we need to make. The plan includes > pulling in changes from whichever BSD was not used as the import. > > >It was shown in the past that OpenBSD's way of doing thing is > >a bit rough on the edges sometimes (humanize_number(3) vs. > >fmt_scaled(3) and scan_scaled(3), ftw(3) and nftw(3), etc). > > If there are edges that we don't like, we can change them. In > my opinion it is hopeless to treat this as a "standard vendor > import" and to *also* combine all changes from Free/Net/Open, > so I am not going to lose any sleep over changing things that > need to be changed. If it wasn't for the fact that FreeBSD > moved patch from usr.bin to gnu/usr.bin many years ago, I would > not even bother with an import. I'd just fix the source which > would already be sitting in this directory -- instead of sitting > in the Attic where it can screw up my import! Thanks for your work. My intention was to get some things straight for me, not to nit pick on people's work. 8-) ./danfe